Start GDB session with API #4864
Open
+48
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4864 +/- ##
=======================================
Coverage 84.07% 84.08%
=======================================
Files 251 251
Lines 28052 28058 +6
=======================================
+ Hits 23586 23592 +6
Misses 4466 4466
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JackThomson2
force-pushed
the
feat/gdb_api_config
branch
from
249596d
to
116e8a9
Compare
JackThomson2
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
kalyazin
reviewed
Oct 22, 2024
Allow a GDB debugging session to be started over API Signed-off-by: Jack Thomson <[email protected]>
JackThomson2
force-pushed
the
feat/gdb_api_config
branch
from
116e8a9
to
3db0436
Compare
Add an entry for the new microVM guest kernel debugging feature Signed-off-by: Jack Thomson <[email protected]>
JackThomson2
force-pushed
the
feat/gdb_api_config
branch
from
3db0436
to
08ff34e
Compare
pb8o
reviewed
Oct 23, 2024
Comment on lines
-28
to
-29
| CONFIG_KGDB=y | ||
| CONFIG_KGDB_SERIAL_CONSOLE=y |
There was a problem hiding this comment.
are these really not needed anymore?
There was a problem hiding this comment.
Yeah not required with this setup
pb8o
added
the
Status: Awaiting author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a GDB debugging session to be started over API
Changes
Moved the GDB address config inside the machine-config section.
This allows a user to start a GDB debugging session using the API and are not limited to just using the config file
Reason
Allow for GDB to be setup when using config file is not possible
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.