-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start GDB session with API #4864
base: main
Are you sure you want to change the base?
Start GDB session with API #4864
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4864 +/- ##
=======================================
Coverage 84.07% 84.08%
=======================================
Files 251 251
Lines 28052 28058 +6
=======================================
+ Hits 23586 23592 +6
Misses 4466 4466
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
249596d
to
116e8a9
Compare
Allow a GDB debugging session to be started over API Signed-off-by: Jack Thomson <[email protected]>
116e8a9
to
3db0436
Compare
Add an entry for the new microVM guest kernel debugging feature Signed-off-by: Jack Thomson <[email protected]>
3db0436
to
08ff34e
Compare
CONFIG_KGDB=y | ||
CONFIG_KGDB_SERIAL_CONSOLE=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these really not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not required with this setup
Allow a GDB debugging session to be started over API
Changes
Moved the GDB address config inside the machine-config section.
This allows a user to start a GDB debugging session using the API and are not limited to just using the config file
Reason
Allow for GDB to be setup when using config file is not possible
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
PR.
CHANGELOG.md
.TODO
s link to an issue.contribution quality standards.
rust-vmm
.