Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset dirty log on full snapshot path #4385

Closed
wants to merge 2 commits into from
Closed

Reset dirty log on full snapshot path #4385

wants to merge 2 commits into from

Commits on Jan 19, 2024

  1. fix: reset dirty log on full snapshot path 

    When a diff snapshot it taken, it always contains all pages that were
dirtied since either instance start, or since the last diff snapshot was
taken, whichever is more recent. This is not what we document it to do:

> the diff consists of the memory pages which have been dirtied since
> the last snapshot creation or since the creation of the microVM,
> whichever of these events was the most recent.

Here "last snapshot creation" includes full snapshots, not just diff
snapshots (and that makes sense, if I take a diff snapshot after a full
snapshot, I expect the diff snapshot to be a diff compared to the full
snapshot).

Signed-off-by: Roman Kovtyukh <[email protected]>
Co-authored-by: Muskaan Singla <[email protected]>
    @Msknsngla @Grandmother
    2 people authored and Grandmother committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    24f3980 View commit details
    Browse the repository at this point in the history

  2. test: full snapshot resets dirty pages 

    Test that taking full snapshot is as described in documentation:

> the diff consists of the memory pages which have been dirtied since
> the last snapshot creation or since the creation of the microVM,
> whichever of these events was the most recent.

Signed-off-by: Roman Kovtyukh <[email protected]>
Co-authored-by: Pablo Barbáchano <[email protected]>
    @pb8o @Grandmother
    pb8o authored and Grandmother committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f996dc6 View commit details
    Browse the repository at this point in the history