fix: Pass through no-API shutdown exit code (main) #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
added
Priority: High
JonathanWoollett-Light
changed the title
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4178 +/- ##
==========================================
- Coverage 83.03% 83.02% -0.01%
==========================================
Files 222 222
Lines 28634 28635 +1
==========================================
Hits 23775 23775
- Misses 4859 4860 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pb8o
reviewed
Oct 17, 2023
JonathanWoollett-Light
force-pushed
the
exit_code_pass_through
branch
13 times, most recently
from
cc5d228
to
aa18f7d
Compare
wearyzen
reviewed
Oct 18, 2023
wearyzen
reviewed
Oct 18, 2023
JonathanWoollett-Light
force-pushed
the
exit_code_pass_through
branch
from
aa18f7d
to
9e0d983
Compare
9 tasks
JonathanWoollett-Light
force-pushed
the
exit_code_pass_through
branch
from
9e0d983
to
af3383b
Compare
JonathanWoollett-Light
requested review from
xmarcalx and
kalyazin
as code owners
JonathanWoollett-Light
force-pushed
the
exit_code_pass_through
branch
from
af3383b
to
ac15af4
Compare
Without passing through the exit code a non-zero exit code was returned on a successful no-API shutdown. Signed-off-by: Jonathan Woollett-Light <[email protected]>
JonathanWoollett-Light
force-pushed
the
exit_code_pass_through
branch
from
ac15af4
to
2db88a4
Compare
pb8o
approved these changes
Oct 18, 2023
wearyzen
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pass through no-API shutdown exit code
Reason
#4176
Without passing through the exit code a non-zero exit code was returned on a successful no-API shutdown.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.