fix: support php 8.4 #583
Merged
fix: support php 8.4 #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds PHP 8.4 to the CI matrix. See firebase#572 and firebase#578
|
@bshaffer Could you approve the workflow so that we can merge (and release) it? Thanks 🙏 |
|
not sure if |
|
Hmm, I will need to look into why the static analysis tests are failing |
|
According to the release please docs it also does a release for deps |
I can fix it, but it happens because PHPStan is not pinned. So this will keep happening because of that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PHP 8.4 to the CI matrix.
See #572 and #578
This is marked as
depsso that release-please picks it up.The previously added support for PHP 8.4 was done as
choreand therefore not released.