Adding optional headers to send in JWT

[mcocaro]

Some services require additional info to be sent in the JOSE header, adding the option for encoding.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[mcocaro]

I signed it!

Martin

On Wed, Jun 17, 2015 at 4:18 PM, googlebot [email protected] wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your
  GitHub username or you're using a different email address. Check your
  existing CLA data https://cla.developers.google.com/clas and verify
  that your email is set on your git commits
  https://help.github.com/articles/setting-your-email-in-git/.
• If you signed the CLA as a corporation, please let us know the
  company's name.

—
Reply to this email directly or view it on GitHub
#53 (comment).

[tuupola]

Do you have any example how and when this is used?

[mcocaro]

yea - check this imp out:

https://github.com/layerhq/support/blob/master/identity-services-samples/php/jwt.php

they require the addition of: 'cty' => 'layer-eit;v=1' as a header

Martin

On Thu, Jun 18, 2015 at 1:35 AM, Mika Tuupola [email protected]
wrote:

Do you have any example how and when this is used?

—
Reply to this email directly or view it on GitHub
#53 (comment).

[robertdimarco]

If $head also contains one of the required fields (typ, alg, or - potentially - kid), this approach would overwrite it, correct? This strikes me as undesirable, but I'm open to other opinions on the matter.

[mcocaro]

it does - thought about that and leaned towards allowing it but to be safe
we can do it the other way around to ensure the other params are not
overwritten, will send updated pr shortly

Martin

On Thu, Jun 18, 2015 at 11:22 AM, Rob DiMarco [email protected]
wrote:

In Authentication/JWT.php
#53 (comment):

 {
     $header = array('typ' => 'JWT', 'alg' => $alg);
     if ($keyId !== null) {
         $header['kid'] = $keyId;
     }

•    if ( isset($head) && is_array($head) ) {
  

•        $header = array_merge($header, $head);
  

If $head also contains one of the required fields (typ,alg, or potentiallykid`),
this approach would overwrite it, correct? This strikes me as undesirable,
but I'm open to other opinions on the matter.

—
Reply to this email directly or view it on GitHub
https://github.com/firebase/php-jwt/pull/53/files#r32761604.

[googlebot]

CLAs look good, thanks!

[googlebot]

CLAs look good, thanks!