Updates example code for Next.js in docs #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthecheung
approved these changes
Sep 12, 2024
|
thank you! |
This is a bit picky, but when I copied the example page.tsx from https://firebase.google.com/docs/genkit/nextjs I found I had some linter errors in my editor. I have updated the example code to: * more closely match React style (varName and setVarName for useState) * reflect good practices in forms (using htmlFor for labels) I also added some spacing to the button, to make it easier to see.
philnash
force-pushed
the
philnash-update-nextjs-starter-code
branch
from
fc28c68
to
2c40c6a
Compare
|
Thanks @MichaelDoyle, a rebase did fix it (at least the formatter was happy locally). I've pushed up the latest, but it needs permission to run the workflows again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit picky, but when I copied the example
page.tsxfrom https://firebase.google.com/docs/genkit/nextjs I found I had some linter errors in my editor.I have updated the example code to:
varNameandsetVarNameforuseState)htmlForfor labels)I also added some spacing to the button, to make it easier to see.
Checklist (if applicable):
N/ATested (manually, unit tested, etc.)N/AChangelog updated