Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otel dependencies #816

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

schnecle
Copy link
Contributor

@schnecle schnecle commented Aug 23, 2024

Otel dependencies that have a dependency on the api package have an upper bound at api 1.9.0, but there are now versions later than 1.9.0.

If a customer project depends directly on 1.9.0, it will cause a peer dependency warning in our code. Upgrading to point to 1.9.0 to stop this warning from happening.

The warning:

Issues with peer dependencies found
.
└─┬ @genkit-ai/core 0.5.9
  └─┬ @opentelemetry/sdk-node 0.49.1
    ├── ✕ unmet peer @opentelemetry/api@">=1.3.0 <1.9.0": found 1.9.0 in @genkit-ai/core
    ├─┬ @opentelemetry/resources 1.22.0
    │ ├── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.9.0": found 1.9.0 in @genkit-ai/core
    │ └─┬ @opentelemetry/core 1.22.0
    │   └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.9.0": found 1.9.0 in @genkit-ai/core
    ├─┬ @opentelemetry/sdk-trace-base 1.22.0
    │ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.9.0": found 1.9.0 in @genkit-ai/core
    ├─┬ @opentelemetry/sdk-metrics 1.22.0
    │ └── ✕ unmet peer @opentelemetry/api@">=1.3.0 <1.9.0": found 1.9.0 in @genkit-ai/core
    ├─┬ @opentelemetry/exporter-trace-otlp-grpc 0.49.1
    │ └─┬ @opentelemetry/otlp-transformer 0.49.1
    │   ├── ✕ unmet peer @opentelemetry/api@">=1.3.0 <1.9.0": found 1.9.0 in @genkit-ai/core
    │   └─┬ @opentelemetry/sdk-logs 0.49.1
    │     └── ✕ unmet peer @opentelemetry/api@">=1.4.0 <1.9.0": found 1.9.0 in @genkit-ai/core
    └─┬ @opentelemetry/sdk-trace-node 1.22.0
      ├── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.9.0": found 1.9.0 in @genkit-ai/core
      ├─┬ @opentelemetry/context-async-hooks 1.22.0
      │ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.9.0": found 1.9.0 in @genkit-ai/core
      ├─┬ @opentelemetry/propagator-jaeger 1.22.0
      │ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.9.0": found 1.9.0 in @genkit-ai/core
      └─┬ @opentelemetry/propagator-b3 1.22.0
        └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.9.0": found 1.9.0 in @genkit-ai/core

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
    Manually tested that telemetry will still flow through with these new versions.
  • Changelog updated
  • Docs updated

@schnecle schnecle merged commit e9d8add into main Aug 23, 2024
4 checks passed
@schnecle schnecle deleted the schnecle/upgrade-otel-dependencies branch August 23, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants