[Eval] Breaking change -- Modify EvalRunKey #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
reviewed
Aug 9, 2024
| @@ -88,7 +88,7 @@ export type EvalResult = z.infer<typeof EvalResultSchema>; | |||
| * A unique identifier for an Evaluation Run. | |||
| */ | |||
| export const EvalRunKeySchema = z.object({ | |||
| actionId: z.string().optional(), | |||
| actionRef: z.string().optional(), | |||
There was a problem hiding this comment.
there are existing/saved eval runs, this change will break those right? Can you add actionRef without removing actionId?
There was a problem hiding this comment.
Yeah it will break.
Yes, that's a good idea. That should be possible.
There was a problem hiding this comment.
Given that main is only for critical fixes, I think we can merge this newer version into next without complications.
shrutip90
approved these changes
Aug 20, 2024
cabljac
added a commit
that referenced
this pull request
Sep 16, 2024
* feat: do not allow defining new actions from within other actions/flows (#725) * refactor: [JS] introduced a generate utility action to make generate veneer logic reusable (#759) Co-authored-by: Michael Bleigh <[email protected]> * refactor: consolidated registry into a class, made registry hierarchical (#639) * Add DatasetStore interfaces for evals datasets (#781) * [Fix] Apply #777 to `next` branch (#779) * Merge main to Next (#792) * Update index.md (#764) * test(go): add live tests to go ollama plugin (#720) * test(go): add ollama live test * test(go): retrieve port info for test container * chore(go): refactor ollama plugin live test * test(go): remove docker from ollama live test * fix context array (#777) * Update to pnpm v9.7.1 (#786) --------- Co-authored-by: Peter Friese <[email protected]> Co-authored-by: Jacob Cable <[email protected]> Co-authored-by: ssbushi <[email protected]> Co-authored-by: Anthony Barone <[email protected]> * [Eval] Breaking change -- Modify EvalRunKey (#755) * Makes inputSchema optional for tools. (#822) * Add datasetId field to eval run key (#827) * Fixes history rendering of Dotprompt system role. (#837) * Local file based DatasetStore implementation and Tools API changes (#797) * feat(js/plugins/ollama): add initial embedding support * feat(js/plugins/ollama): integrate ollama embeddings into plugin proper * Update js/plugins/ollama/src/embeddings.ts Co-authored-by: Pavel Jbanov <[email protected]> --------- Co-authored-by: Pavel Jbanov <[email protected]> Co-authored-by: Michael Bleigh <[email protected]> Co-authored-by: shrutip90 <[email protected]> Co-authored-by: ssbushi <[email protected]> Co-authored-by: Sam Phillips <[email protected]> Co-authored-by: Peter Friese <[email protected]> Co-authored-by: Anthony Barone <[email protected]> Co-authored-by: Michael Doyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
actionIdtoactionRef, stores the full action path. Must be submitted along with https://github.com/FirebasePrivate/genkit-ui/pull/1001Checklist (if applicable):