Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logging to ensure correct context for span #533

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Move logging to ensure correct context for span #533

merged 2 commits into from
Jul 4, 2024

Conversation

andrewbrook
Copy link
Contributor

Move logging for generate action to ensure correct context for span

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)

@andrewbrook andrewbrook marked this pull request as ready for review July 3, 2024 17:44
kmandrika
kmandrika reviewed Jul 3, 2024
View reviewed changes
js/ai/src/model.ts Outdated Show resolved Hide resolved
@andrewbrook andrewbrook merged commit 627d277 into main Jul 4, 2024
4 checks passed
@andrewbrook andrewbrook deleted the generate_metrics branch July 4, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmandrika kmandrika kmandrika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewbrook @kmandrika