Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array of toolNames to CreatePromptRequest #275

Merged
merged 1 commit into from
May 29, 2024

Conversation

MaesterChestnut
Copy link
Contributor

@MaesterChestnut MaesterChestnut commented May 29, 2024

Adding the toolNames property to CreatePromptRequestSchema which will then get passed to the PromptFormatter used to export prompts from the Prompt Runner and Model Runner. I used the property toolNames instead of tools to prevent incompatibility with the main branch of the genkit-ui which sends tools as a ToolDefinitionSchema object.

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
    Manually tested without UI changes to ensure this is a non-breaking change
  • Changelog updated
  • Docs updated

@MaesterChestnut MaesterChestnut marked this pull request as ready for review May 29, 2024 17:37
@MaesterChestnut MaesterChestnut merged commit f4d9852 into main May 29, 2024
4 checks passed
@MaesterChestnut MaesterChestnut deleted the cc/addToolsToDotPromptExport branch May 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants