Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin docs to include explicit imports #238

Closed
wants to merge 2 commits into from

Conversation

i2amsam
Copy link
Contributor

@i2amsam i2amsam commented May 23, 2024

No description provided.

@kevinthecheung
Copy link
Contributor

I don't oppose this but we got internal feedback that the way the snippets looked with import statements implied that the snippets could be copy pasted as complete working examples which is often not the case.

In other languages, I would just rely on IDE auto-completion, but it seems to rarely work for typescript/vs code, at least for me.

@i2amsam
Copy link
Contributor Author

i2amsam commented May 23, 2024

I don't oppose this but we got internal feedback that the way the snippets looked with import statements implied that the snippets could be copy pasted as complete working examples which is often not the case.

In other languages, I would just rely on IDE auto-completion, but it seems to rarely work for typescript/vs code, at least for me.

I don't oppose this but we got internal feedback that the way the snippets looked with import statements implied that the snippets could be copy pasted as complete working examples which is often not the case.

In other languages, I would just rely on IDE auto-completion, but it seems to rarely work for typescript/vs code, at least for me.

Hmmmm, that's a fair point. I just did some testing with a sample project and was able to get too autocompletion for these pretty smoothly. Let me dig in more

@i2amsam
Copy link
Contributor Author

i2amsam commented May 29, 2024

I don't oppose this but we got internal feedback that the way the snippets looked with import statements implied that the snippets could be copy pasted as complete working examples which is often not the case.
In other languages, I would just rely on IDE auto-completion, but it seems to rarely work for typescript/vs code, at least for me.

I don't oppose this but we got internal feedback that the way the snippets looked with import statements implied that the snippets could be copy pasted as complete working examples which is often not the case.
In other languages, I would just rely on IDE auto-completion, but it seems to rarely work for typescript/vs code, at least for me.

Hmmmm, that's a fair point. I just did some testing with a sample project and was able to get too autocompletion for these pretty smoothly. Let me dig in more

In my testing I was able to get "Quick fixes" in VSCode for these imports, so closing this for now

@i2amsam i2amsam closed this May 29, 2024
@i2amsam i2amsam deleted the samphillips-update-imports branch May 29, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants