Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: got rid of runWithRegistry and most vestiges of global registry #1091

Merged
merged 1 commit into from
Oct 22, 2024
Merged

breaking: got rid of runWithRegistry and most vestiges of global registry #1091

merged 1 commit into from
Oct 22, 2024

Conversation

pavelgj
Copy link
Collaborator

@pavelgj pavelgj commented Oct 22, 2024

No description provided.

maxl0rd
maxl0rd approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@maxl0rd maxl0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I can fix the tests in the google-cloud plugin after this is merged.

js/genkit/src/genkit.ts Show resolved Hide resolved
@maxl0rd maxl0rd mentioned this pull request Oct 22, 2024
Open
@pavelgj pavelgj merged commit 3540696 into next Oct 22, 2024
4 checks passed
@pavelgj pavelgj deleted the pj/registryCleanup branch October 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxl0rd maxl0rd maxl0rd approved these changes

@apascal07 apascal07 Awaiting requested review from apascal07

@MichaelDoyle MichaelDoyle Awaiting requested review from MichaelDoyle

Assignees
No one assigned
Labels
None yet
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelgj @maxl0rd