Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_messaging): Support for multiple senderId (Android) #3936

Closed
wants to merge 2 commits into from

Conversation

xurei
Copy link

@xurei xurei commented Oct 22, 2020

Description

This implements the multiple senderId features as described in the offical doc.

  • Add optional parameter senderId in FirebaseMessaging.configure(), FirebaseMessaging.getToken() and FirebaseMessaging.deleteInstanceID()
  • Modified the Java class FirebaseMessagingPlugin to handle the changes.
  • Updated the test to check both the default (no senderId) and the secondary.

This requires maintainers input

I don't believe this PR is ready as-is.

I identified two issues:

  1. The iOS native code needs to be updated (note that it still works but does not account for senderId yet). I'm not very fluent with Objective-C, so any help would be appreciated :-)
  2. More importantly: the onTokenRefresh is fired for all the token updates (primary and secondary). I didn't change this to keep the code retro-compatible.
    However, for completeness, it would be better to send the token and the senderId in onTokenRefresh, but this is a breaking change.
    Another option is to deprecate onTokenRefresh an create another method.

What do you think ?

Related Issues

No issue found.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Oct 22, 2020
@xurei xurei changed the title feat(firebase_messaging) Support for multiple senderId (Android) feat(firebase_messaging): Support for multiple senderId (Android) Oct 22, 2020
@Salakar Salakar closed this in #4012 Nov 3, 2020
@firebase firebase locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant