Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firebase_remote_config): migrate to use new firebase_core. #3066

Merged
merged 14 commits into from
Jul 31, 2020

Conversation

Salakar
Copy link
Member

@Salakar Salakar commented Jul 31, 2020

Description

  • Depend on new firebase_core (pre-release).
  • Firebase iOS SDK versions are now locked to use the same version defined in
    firebase_core.
  • Firebase Android SDK versions are now using the Firebase Bill of Materials (BoM)
    to specify individual SDK versions. BoM version is also sourced from
    firebase_core.
  • Added support for MacOS. (Add macOS support #1653)
  • Allow iOS & MacOS plugins to be imported as modules.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Local Testing

Android & iOS:

image

MacOS:
image

@Salakar Salakar marked this pull request as ready for review July 31, 2020 11:32
@Salakar Salakar merged commit 83d4183 into master Jul 31, 2020
@Salakar Salakar deleted the @invertase/core-migration-2 branch July 31, 2020 13:13
@firebase firebase locked and limited conversation to collaborators Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants