[firebase_messaging] Declares Android Firebase Messaging dependency as api
#1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Feb 20, 2020
| @@ -61,18 +61,6 @@ for more. | |||
|
|
|||
| By default background messaging is not enabled. To handle messages in the background: | |||
|
|
|||
| 1. Add the `com.google.firebase:firebase-messaging` dependency in your app-level `build.gradle` file that is typically located at `<app-name>/android/app/build.gradle`. | |||
There was a problem hiding this comment.
What happens to apps that have already followed this step when they receive this change? Will gradle complain in an actionable way, or is this going to break consumers of the plugin?
There was a problem hiding this comment.
No there won't be any conflicts, the user would effectively just be redeclaring a dependency already available to them. Gradles dependency resolution will handle everything.
…o be accessed from the app An app shouldn’t have to define the the Firebase Messaging dependency in order to access it, as it’s already included within this plugin. By declaring it as an `api` dependency, this allows the app to access it and removes an extra step from the setup.
josh-burton
force-pushed
the
firebase-messaging-api-dependency
branch
from
11a8887
to
5a65868
Compare
|
@kroikie any chance of a review here? |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An app shouldn’t have to define the the Firebase Messaging dependency in order to access it, as it’s already included within this plugin. By declaring it as an
apidependency, this allows the app to access it and removes an extra step from the setup.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?