Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_core_platform_interface): move test APIs to test.dart #16672

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Nov 15, 2024

BREAKING CHANGE: move testing apis to a new library: test.dart

This fixes analysis of this package and dependents

BREAKING CHANGE: move testing apis to a new library: test.dart

This fixes analysis of this package and dependents
@kevmoo kevmoo changed the title fix wasm analysis fix(firebase_core_platform_interface)!: move test APIs to test.dart Nov 15, 2024
@kevmoo kevmoo marked this pull request as ready for review November 15, 2024 01:10
@Lyokone Lyokone changed the title fix(firebase_core_platform_interface)!: move test APIs to test.dart fix(firebase_core_platform_interface): move test APIs to test.dart Nov 15, 2024
@Lyokone Lyokone merged commit a80a2ef into main Nov 15, 2024
29 of 30 checks passed
@Lyokone Lyokone deleted the wasm_issue branch November 15, 2024 10:45
Lyokone pushed a commit that referenced this pull request Dec 4, 2024
…16672)

This fixes analysis of this package and dependents

* fix lib header
@arktronic
Copy link

Why was this BREAKING CHANGE published as a patch version of 5.3.1?

@kevmoo
Copy link
Collaborator Author

kevmoo commented Dec 5, 2024

Why was this BREAKING CHANGE published as a patch version of 5.3.1?

I wasn't involved in the versioning discussion of this change.

What broken on your side? How are you using the test features?

And also: sorry for the pain. Are you able to work-around the issues?

@arktronic
Copy link

Multiple CI pipelines broke because of tests being unable to execute. We worked around the issue by pinning version 5.3.0. I just wanted to inform whomever is involved with the release/versioning process that this should have been a major version bump, rather than a patch bump. Thanks!

@firebase firebase locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants