Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): update to web: ^1.0.0 #13200

Merged
merged 25 commits into from
Sep 10, 2024
Merged

feat(web): update to web: ^1.0.0 #13200

merged 25 commits into from
Sep 10, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Aug 20, 2024

Description

If you want to use this PR early, you can use latest version of FlutterFire CLI

dart pub global activate flutterfire_cli 1.0.1-dev.4 --overwrite
flutterfire install git:feat/update-web100

Related Issues

closes #13190

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@mj-shifu
Copy link

Hello @Lyokone, thank you for creating this PR! I tested it out and encountered an issue with phone number authentication:

Type '_TypeError' is not a subtype of type 'JSValue' in type cast.

After some investigation, I found that changing line 103 of packages/firebase_auth/firebase_auth_web/lib/src/firebase_auth_web_recaptcha_verifier_factory.dart to this resolved the issue for me:

    _delegate = auth_interop.RecaptchaVerifier(
-      element,
+      element.toJS,
      parameters,
      auth.delegate,
    );

Would you be open to including this fix in your PR? This would help me depend on it directly.

@Lyokone
Copy link
Contributor Author

Lyokone commented Aug 20, 2024

@mj-shifu thanks so much for noticing 👍 We have some dynamic left here and there from the first implementation 😓 I've pushed the fix

@faheemstepsharp
Copy link

latest version should be used

@RicharC293
Copy link

How long does it take for this update to be released and available on pub.dev?

@millerf
Copy link

millerf commented Aug 21, 2024

I would love this to be merged as well. This dependency is blocking quite some of my other dependencies

@T-P-F
Copy link

T-P-F commented Aug 26, 2024

@russellwheatley @Salakar this PR unblocks a train of dependency updates that grows longer by the day....

@mghali1
Copy link

mghali1 commented Aug 28, 2024

@russellwheatley @Salakar please review this PR asap. A lot of depedencies are being blocked by this. Thank you.

@millerf
Copy link

millerf commented Aug 29, 2024

@Lyokone This

dart pub global activate flutterfire_cli 1.0.1-dev.4 --overwrite
flutterfire install git:feat/update-web100

Did not work for me... The latter command failed.

@millerf
Copy link

millerf commented Aug 29, 2024

Also, side question: I am actually not using flutter on web, so I was wondering if there was a way to prevent this dependency to be used altogether from my project pubspec.yaml. It infuriating that a dependency I do not use prevents me to update other things.
Or maybe I should just override the web dependency!? 🤔🎉

@amrgetment
Copy link

@millerf Unfortunately, the web package was in beta, but it is now stable 1.0.0, it will have less frequent updates or breaking changes

@Lyokone
Copy link
Contributor Author

Lyokone commented Aug 30, 2024

Hello, this PR has attracted a lot of attention. We are not ready to force users to upgrade to Dart 3.4 (which is required for us to add support for web: ^1.0.0.
We are expecting to make Dart 3.4 required in the coming weeks. You still can depend on this PR or override the web version if needed.

@josh-burton
Copy link
Contributor

josh-burton commented Sep 3, 2024

@Lyokone getting some typeerrors in web_utils convertPlatformActionCodeSettings method:

if (actionCodeSettingsMap['android'] != null) {

The AndroidSettings and IOSSettings fields are not being converted to JS. This works:

if (actionCodeSettingsMap['android'] != null) {
    webActionCodeSettings.android = auth_interop.AndroidSettings(
      packageName: (actionCodeSettingsMap['android']['packageName'] as String?)?.toJS,
      minimumVersion: (actionCodeSettingsMap['android']['minimumVersion'] as String?)?.toJS,
      installApp: (actionCodeSettingsMap['android']['installApp'] as bool?)?.toJS,
    );
  }

  if (actionCodeSettingsMap['iOS'] != null) {
    webActionCodeSettings.iOS = auth_interop.IosSettings(
      bundleId: (actionCodeSettingsMap['iOS']['bundleId'] as String?)?.toJS,
    );
  }

PR here: #13260

@sagar1garg
Copy link

@Lyokone pls release an update with this PR asap. A lot of packages are stuck only because of this

@sagar1garg
Copy link

Hello, this PR has attracted a lot of attention. We are not ready to force users to upgrade to Dart 3.4 (which is required for us to add support for web: ^1.0.0. We are expecting to make Dart 3.4 required in the coming weeks. You still can depend on this PR or override the web version if needed.

The existing package is not compatible with web^1.0.0 so it won't overwrite as well

@Lyokone Lyokone merged commit 8fab04a into main Sep 10, 2024
21 of 25 checks passed
@Lyokone Lyokone deleted the feat/update-web100 branch September 10, 2024 14:05
@millerf
Copy link

millerf commented Sep 10, 2024

Nice! Thanks for working on it everyone! Will it be deployed on pub.dev soon?

@Kuhlemann
Copy link

It is now deployed.

@firebase firebase locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web]: Dependency issue with other package using web: ^1.0.0