Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension crash when there is no root folder. #8055

Conversation

yuchenshi
Copy link
Member

Description

This happens when opening VS Code without opening a folder.

Scenarios Tested

lol not really

Sample Commands

N/A

Created using spr 1.3.6-beta.1
@yuchenshi yuchenshi requested a review from joehan December 11, 2024 22:08
Created using spr 1.3.6-beta.1
@yuchenshi
Copy link
Member Author

The real change is in a4aa3e0 , the one before is just prettier formatting

@yuchenshi yuchenshi marked this pull request as ready for review December 11, 2024 22:09
@yuchenshi yuchenshi enabled auto-merge (squash) December 12, 2024 17:02
@yuchenshi yuchenshi merged commit c3896ad into master Dec 12, 2024
43 of 46 checks passed
@yuchenshi yuchenshi deleted the spr/yuchenshi/fix-extension-crash-when-there-is-no-root-folder branch December 12, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants