-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print instructions to assist FDC Onboard Flow #7802
Conversation
@@ -314,13 +316,14 @@ async function checkExistingInstances( | |||
}); | |||
} | |||
} | |||
} else { | |||
info = await promptForService(info); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should ask this question and csql ones after "Would you like to configure your backend resources now?"
@@ -74,22 +74,29 @@ const defaultSchema = { path: "schema.gql", content: SCHEMA_TEMPLATE }; | |||
|
|||
// doSetup is split into 2 phases - ask questions and then actuate files and API calls based on those answers. | |||
export async function doSetup(setup: Setup, config: Config): Promise<void> { | |||
const info = await askQuestions(setup); | |||
const isBillingEnabled = setup.projectId ? await checkBillingEnabled(setup.projectId) : false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional, canbe done later: Checking billing status is probably appropriate to do in init/index.ts and then passed around in setup, since it won't change from product to product.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are talking about making it accessible in Setup
for all products, right?
Yeah, that can be optimized later.
Description
Print instructions to follow through in the Spark plan upgrade CUJ in the local getting start guide.
Customer could follow through the whole journey even if they aren't reading documentation. CLI (and VS Code buttons) is self-contained.
Scenarios Tested
Spark Project init => upgrade => init again => deploy
In a Spark Project, run init. (no prompt at all)
In a Spark Project, run deploy
After upgrade plan, run init again (accept all defaults)
Spark Project init => upgrade => create service in console => init again => deploy
Same first two steps as above.
After creating service in console, run
init
to pull down configs. (accept all defaults)Blaze Project init => deploy
In a Blaze plan, run init. (accept all defaults)
Deploy works afterwards. If CSQL is still being created, you see