Print instructions to assist FDC Onboard Flow #7802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzqm
commented
Oct 7, 2024
| @@ -314,13 +316,14 @@ async function checkExistingInstances( | |||
| }); | |||
| } | |||
| } | |||
| } else { | |||
| info = await promptForService(info); | |||
There was a problem hiding this comment.
We should ask this question and csql ones after "Would you like to configure your backend resources now?"
fredzqm
changed the title
joehan
approved these changes
Oct 7, 2024
| @@ -74,22 +74,29 @@ const defaultSchema = { path: "schema.gql", content: SCHEMA_TEMPLATE }; | |||
|
|
|||
| // doSetup is split into 2 phases - ask questions and then actuate files and API calls based on those answers. | |||
| export async function doSetup(setup: Setup, config: Config): Promise<void> { | |||
| const info = await askQuestions(setup); | |||
| const isBillingEnabled = setup.projectId ? await checkBillingEnabled(setup.projectId) : false; | |||
There was a problem hiding this comment.
Optional, canbe done later: Checking billing status is probably appropriate to do in init/index.ts and then passed around in setup, since it won't change from product to product.
There was a problem hiding this comment.
You are talking about making it accessible in Setup for all products, right?
Yeah, that can be optimized later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Print instructions to follow through in the Spark plan upgrade CUJ in the local getting start guide.
Customer could follow through the whole journey even if they aren't reading documentation. CLI (and VS Code buttons) is self-contained.
Scenarios Tested
Spark Project init => upgrade => init again => deploy
In a Spark Project, run init. (no prompt at all)
In a Spark Project, run deploy
After upgrade plan, run init again (accept all defaults)
Spark Project init => upgrade => create service in console => init again => deploy
Same first two steps as above.
After creating service in console, run
initto pull down configs. (accept all defaults)Blaze Project init => deploy
In a Blaze plan, run init. (accept all defaults)
Deploy works afterwards. If CSQL is still being created, you see