Allow GCB repos to be reused in backend.

src/init/features/frameworks/repo.ts

@@ -17,13 +17,13 @@
 const FRAMEWORKS_CONN_PATTERN = /.+\/frameworks-github-conn-.+$/;
 const FRAMEWORKS_OAUTH_CONN_NAME = "frameworks-github-oauth";
 const CONNECTION_NAME_REGEX =
   /^projects\/(?<projectId>[^\/]+)\/locations\/(?<location>[^\/]+)\/connections\/(?<id>[^\/]+)$/;
 
 /**
  * Exported for unit testing.
  */
 export function parseConnectionName(name: string): ConnectionNameParts | undefined {
   const match = name.match(CONNECTION_NAME_REGEX);
 
   if (!match || typeof match.groups === undefined) {
     return;
@@ -112,7 +112,7 @@
   }
 
   // Ensure that the selected connection exists in the same region as the backend
   const { id: connectionId } = parseConnectionName(connection.name)!;
   await getOrCreateConnection(projectId, location, connectionId, {
     authorizerCredential: connection.githubConfig?.authorizerCredential,
     appInstallationId: connection.githubConfig?.appInstallationId,
@@ -130,7 +130,7 @@
 ): Promise<{ remoteUri: string; connection: gcb.Connection }> {
   const remoteUriToConnection: Record<string, gcb.Connection> = {};
   for (const conn of connections) {
     const { id } = parseConnectionName(conn.name)!;
     const resp = await gcb.fetchLinkableRepositories(projectId, location, id);
     if (resp.repositories && resp.repositories.length > 1) {
       for (const repo of resp.repositories) {
@@ -148,12 +148,12 @@
     value: "",
   });
 
   const remoteUri = await promptOnce({
     type: "list",
     message: "Which of the following repositories would you like to deploy?",
     choices,
   });
   return { remoteUri, connection: remoteUriToConnection[remoteUri] };
 }
 
 async function promptConnectionAuth(conn: gcb.Connection): Promise<gcb.Connection> {
@@ -169,7 +169,7 @@
     message: "Press Enter once you have authorized the app",
   });
   cleanup();
   const { projectId, location, id } = parseConnectionName(conn.name)!;
   return await gcb.getConnection(projectId, location, id);
 }
 
@@ -240,10 +240,6 @@
   let repo: gcb.Repository;
   try {
     repo = await gcb.getRepository(projectId, location, connectionId, repositoryId);
-    const repoSlug = extractRepoSlugFromUri(repo.remoteUri);
-    if (repoSlug) {
-      throw new FirebaseError(`${repoSlug} has already been linked.`);
-    }
   } catch (err: unknown) {
     if ((err as FirebaseError).status === 404) {
       const op = await gcb.createRepository(

src/test/init/frameworks/repo.spec.ts

@@ -128,6 +128,21 @@ describe("composer", () => {
       );
     });
 
+    it("re-uses existing repository it already exists", async () => {
+      getConnectionStub.resolves(completeConn);
+      fetchLinkableRepositoriesStub.resolves(repos);
+      promptOnceStub.onFirstCall().resolves(repos.repositories[0].remoteUri);
+      getRepositoryStub.resolves(repos.repositories[0]);
+
+      const r = await repo.getOrCreateRepository(
+        projectId,
+        location,
+        connectionId,
+        repos.repositories[0].remoteUri
+      );
+      expect(r).to.be.deep.equal(repos.repositories[0]);
+    });
+
     it("throws error if no linkable repositories are available", async () => {
       getConnectionStub.resolves(pendingConn);
       fetchLinkableRepositoriesStub.resolves({ repositories: [] });