Revert "Enable preferRest option by default for Firestore functions"

CHANGELOG.md

@@ -1,3 +1,4 @@
+- Revert enabling preferRest by default to avoid performance degradations for some users (#6520).
 - Fix blocking functions in the emulator when using multiple codebases (#6504).
 - Add force flag call-out for bypassing prompts (#6506).
 - Fixed an issue where the functions emulator did not respect the `--log-verbosity` flag (#2859).

src/functions/env.ts

@@ -195,8 +195,8 @@
   for (const key of Object.keys(envs)) {
     try {
       validateKey(key);
     } catch (err: any) {
       logger.debug(`Failed to validate key ${key}: ${err}`);
       if (err instanceof KeyValidationError) {
         validationErrors.push(err);
       } else {
@@ -260,7 +260,7 @@
  * Identifies one and only one dotenv file to touch using the same rules as loadUserEnvs().
  * It is an error to provide a key-value pair which is already in the file.
  */
 export function writeUserEnvs(toWrite: Record<string, string>, envOpts: UserEnvsOpts) {
   if (Object.keys(toWrite).length === 0) {
     return;
   }
@@ -316,9 +316,9 @@
   envsWithoutLocal?: Record<string, string>
 ): void {
   for (const key of keys) {
     const definedInEnv = fullEnv.hasOwnProperty(key);
     if (definedInEnv) {
       if (envsWithoutLocal && isEmulator && envsWithoutLocal.hasOwnProperty(key)) {
         logWarning(
           clc.cyan(clc.yellow("functions: ")) +
             `Writing parameter ${key} to emulator-specific config .env.local. This will overwrite your existing definition only when emulating.`
@@ -384,10 +384,10 @@
     try {
       const data = fs.readFileSync(path.join(functionsSource, f), "utf8");
       envs = { ...envs, ...parseStrict(data) };
     } catch (err: any) {
       throw new FirebaseError(`Failed to load environment variables from ${f}.`, {
         exit: 2,
         children: err.children?.length > 0 ? err.children : [err],
       });
     }
   }
@@ -404,12 +404,11 @@
  * @return Environment varibles for functions.
  */
 export function loadFirebaseEnvs(
   firebaseConfig: Record<string, any>,
   projectId: string
 ): Record<string, string> {
   return {
     FIREBASE_CONFIG: JSON.stringify(firebaseConfig),
     GCLOUD_PROJECT: projectId,
-    FIRESTORE_PREFER_REST: "true",
   };
 }