Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for system params when deploying extensions #5414

Merged
merged 6 commits into from
Jan 13, 2023

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Jan 11, 2023

Description

Adds support for configuring system params when installing or updating extension instances, as described in go/firex-resource-params-api. This feature is currently guarded behind a backend experiment.

To do in follow up PRs:

  • Add special handling for mapping LOCATION to firebaseextensions.v1beta.function/location when updating instances
  • Add emulator support
  • Add support for hiding advanced params behind an extra prompt

Scenarios Tested

Successfully deployed an extension instance with its location configured to us-east4 via system params, and verified that the underlying functions where deployed to us-east4

@joehan joehan requested review from pavelgj and apascal07 January 11, 2023 23:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Base: 56.33% // Head: 56.32% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (279ef81) compared to base (177c99d).
Patch coverage: 43.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5414      +/-   ##
==========================================
- Coverage   56.33%   56.32%   -0.01%     
==========================================
  Files         315      315              
  Lines       21303    21324      +21     
  Branches     4343     4349       +6     
==========================================
+ Hits        12000    12011      +11     
- Misses       8264     8272       +8     
- Partials     1039     1041       +2     
Impacted Files Coverage Δ
src/deploy/extensions/tasks.ts 18.64% <ø> (ø)
src/extensions/types.ts 100.00% <ø> (ø)
src/functions/env.ts 95.90% <ø> (ø)
src/deploy/extensions/planner.ts 51.21% <18.18%> (-0.07%) ⬇️
src/extensions/paramHelper.ts 80.20% <33.33%> (-1.52%) ⬇️
src/extensions/extensionsApi.ts 66.94% <40.00%> (-1.17%) ⬇️
src/functional.ts 91.48% <100.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joehan joehan enabled auto-merge (squash) January 13, 2023 22:02
@joehan joehan merged commit 1756213 into master Jan 13, 2023
@joehan joehan deleted the jh-system-params branch January 17, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants