Update changelog

CHANGELOG.md

@@ -1,4 +1 @@
-- Fixed Flutter web apps that might require the --no-tree-shake-icons flag in order to build. (#7724)
-- Removed outdated dependency on `rimraf`.
-- Fixed an issue where the Extensions emulator would fail silently if started with a non-existant project without the `demo-` prefix. (#7779)
 - Added new command dataconnect:sql:shell which allows users to directly connect and run queries against their dataconnect cloudsql instance (#7778).

firebase-vscode/CHANGELOG.md

@@ -1,5 +1,7 @@
 ## NEXT
 
+## 0.10.5
+
 - [Fixed] Fixed an issue where multiple instances of the extension would break the toolkit.
 
 ## 0.10.4

firebase-vscode/package.json

@@ -4,7 +4,7 @@
   "publisher": "GoogleCloudTools",
   "icon": "./resources/firebase_dataconnect_logo.png",
   "description": "Firebase Data Connect for VSCode",
-  "version": "0.10.4",
+  "version": "0.10.5",
   "engines": {
     "vscode": "^1.69.0"
   },

firebase-vscode/src/core/index.ts

@@ -3,7 +3,7 @@ import { ExtensionBrokerImpl } from "../extension-broker";
 import { getRootFolders, registerConfig } from "./config";
 import { EmulatorsController } from "./emulators";
 import { registerEnv } from "./env";
-import { pluginLogger, LogLevel } from '../logger-wrapper';
+import { pluginLogger, LogLevel } from "../logger-wrapper";
 import { getSettings } from "../utils/settings";
 import { setEnabled } from "../../../src/experiments";
 import { registerUser } from "./user";
@@ -55,18 +55,18 @@ export async function registerCore(
       return;
     }
     const workspaceFolder = vscode.workspace.workspaceFolders[0];
-    const initCommand = currentProjectId.value ? 
-      `${settings.firebasePath} init dataconnect --project ${currentProjectId.value}` :
-      `${settings.firebasePath} init dataconnect`;
-    vscode.tasks.executeTask(
-      new vscode.Task(
-        { type: "shell" }, // this is the same type as in tasks.json
-        workspaceFolder, // The workspace folder
-        "firebase init dataconnect", // how you name the task
-        "firebase init dataconnect", // Shows up as MyTask: name
-        new vscode.ShellExecution(initCommand),
-      ),
+    const initCommand = currentProjectId.value
+      ? `${settings.firebasePath} init dataconnect --project ${currentProjectId.value}`
+      : `${settings.firebasePath} init dataconnect`;
+    const task = new vscode.Task(
+      { type: "shell" }, // this is the same type as in tasks.json
+      workspaceFolder, // The workspace folder
+      "firebase init dataconnect", // how you name the task
+      "firebase init dataconnect", // Shows up as MyTask: name
+      new vscode.ShellExecution(initCommand),
     );
+    task.presentationOptions = { focus: true };
+    vscode.tasks.executeTask(task);
   });
 
   const emulatorsController = new EmulatorsController(broker);
@@ -84,7 +84,9 @@ export async function registerCore(
     "firebase.refresh",
     async () => {
       await vscode.commands.executeCommand("workbench.action.closeSidebar");
-      await vscode.commands.executeCommand("workbench.view.extension.firebase-data-connect");
+      await vscode.commands.executeCommand(
+        "workbench.view.extension.firebase-data-connect",
+      );
     },
   );
 

firebase-vscode/src/data-connect/terminal.ts

@@ -36,6 +36,7 @@ export function runCommand(command: string) {
 export function runTerminalTask(
   taskName: string,
   command: string,
+  presentationOptions: vscode.TaskPresentationOptions = { focus: true },
 ): Promise<string> {
   const type = "firebase-" + Date.now();
   return new Promise(async (resolve, reject) => {
@@ -54,15 +55,15 @@ export function runTerminalTask(
         }
       }
     });
-    const task = await vscode.tasks.executeTask(
-      new vscode.Task(
-        { type },
-        vscode.TaskScope.Workspace,
-        taskName,
-        "firebase",
-        new vscode.ShellExecution(command, executionOptions),
-      ),
+    const task = new vscode.Task(
+      { type },
+      vscode.TaskScope.Workspace,
+      taskName,
+      "firebase",
+      new vscode.ShellExecution(command, executionOptions),
     );
+    task.presentationOptions = presentationOptions;
+    await vscode.tasks.executeTask(task);
   });
 }
 
@@ -88,6 +89,8 @@ export function registerTerminalTasks(
     runTerminalTask(
       "firebase emulators",
       `${settings.firebasePath} emulators:start --project ${currentProjectId.value}`,
+      // emulators:start almost never ask interactive questions.
+      { focus: false },
     );
   });
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-tools",
-  "version": "13.22.0",
+  "version": "13.22.1",
   "description": "Command-Line Interface for Firebase",
   "main": "./lib/index.js",
   "bin": {

src/apiv2.ts

@@ -476,13 +476,13 @@ export class Client {
             setAccessToken(await getAccessToken());
           }
           if (options.retryCodes?.includes(res.status)) {
-            const err = responseToError({ statusCode: res.status }, body) || undefined;
+            const err = responseToError({ statusCode: res.status }, body, fetchURL) || undefined;
             if (operation.retry(err)) {
               return;
             }
           }
           if (!options.resolveOnHTTPError) {
-            return reject(responseToError({ statusCode: res.status }, body));
+            return reject(responseToError({ statusCode: res.status }, body, fetchURL));
           }
         }