Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC: Modified user agent to use language instead of platform #8565

Merged
merged 3 commits into from
Oct 14, 2024
Merged

FDC: Modified user agent to use language instead of platform #8565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd7088c
Renamed js to web
maneesht Oct 11, 2024
9839735
Create tall-birds-protect.md
maneesht Oct 11, 2024
0fe22d5
Update tall-birds-protect.md
maneesht Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-birds-protect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@firebase/data-connect": patch
---

- Modified user agent to use language instead of platform
2 changes: 1 addition & 1 deletion packages/data-connect/src/network/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function initializeFetch(fetchImpl: typeof fetch): void {
function getGoogApiClientValue(_isUsingGen: boolean): string {
let str = 'gl-js/ fire/' + SDK_VERSION;
if (_isUsingGen) {
str += ' web/gen';
str += ' js/gen';
}
return str;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/data-connect/test/unit/userAgent.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe('User Agent Tests', () => {
'https://firebasedataconnect.googleapis.com/v1beta/projects/p/locations/l/services/s/connectors/c:executeQuery',
{
headers: {
['X-Goog-Api-Client']: 'gl-js/ fire/' + SDK_VERSION + ' web/gen'
['X-Goog-Api-Client']: 'gl-js/ fire/' + SDK_VERSION + ' js/gen'
}
}
);
Expand Down
Loading