Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update endpoint to Clearlog #8534

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Update endpoint to Clearlog #8534

merged 3 commits into from
Sep 30, 2024

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Sep 25, 2024

Here’s a refined version of your GitHub PR description:

Context: The logging endpoint has been updated in accordance with go/firelog. We observed that BigQuery logging is missing entries for WebPush (see b/350475783 for reference). This PR addresses the issue by updating both the endpoint and the payload to ensure proper logging of WebPush entries.

@zwu52 zwu52 requested a review from a team as a code owner September 25, 2024 19:53
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 843657a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/messaging Patch
firebase Patch
@firebase/messaging-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zwu52 zwu52 requested review from a team as code owners September 25, 2024 20:03
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/messaging

    TypeBase (beaa4df)Merge (3c5ce6d)Diff
    browser21.3 kB21.3 kB-84 B (-0.4%)
    esm526.8 kB26.7 kB-84 B (-0.3%)
    main27.4 kB27.4 kB-84 B (-0.3%)
    module21.3 kB21.3 kB-84 B (-0.4%)

  • @firebase/messaging-sw

    TypeBase (beaa4df)Merge (3c5ce6d)Diff
    main30.4 kB30.4 kB-59 B (-0.2%)
    module23.6 kB23.5 kB-59 B (-0.3%)

  • bundle

    TypeBase (beaa4df)Merge (3c5ce6d)Diff
    messaging (send + receive)47.0 kB46.9 kB-73 B (-0.2%)

  • firebase

    TypeBase (beaa4df)Merge (3c5ce6d)Diff
    firebase-compat.js788 kB788 kB-143 B (-0.0%)
    firebase-messaging-compat.js38.4 kB38.3 kB-143 B (-0.4%)
    firebase-messaging-sw.js30.2 kB30.1 kB-71 B (-0.2%)
    firebase-messaging.js28.7 kB28.7 kB-96 B (-0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/anKY9p7l5l.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/messaging

    • deleteToken

      Size

      TypeBase (beaa4df)Merge (3c5ce6d)Diff
      size12.7 kB12.7 kB-72 B (-0.6%)
      size-with-ext-deps39.5 kB39.4 kB-73 B (-0.2%)

    • getMessaging

      Size

      TypeBase (beaa4df)Merge (3c5ce6d)Diff
      size12.8 kB12.7 kB-73 B (-0.6%)
      size-with-ext-deps46.7 kB46.6 kB-73 B (-0.2%)

    • getToken

      Size

      TypeBase (beaa4df)Merge (3c5ce6d)Diff
      size12.2 kB12.2 kB-72 B (-0.6%)
      size-with-ext-deps39.0 kB38.9 kB-73 B (-0.2%)

    • isSupported

      Size

      TypeBase (beaa4df)Merge (3c5ce6d)Diff
      size12.6 kB12.5 kB-72 B (-0.6%)
      size-with-ext-deps39.3 kB39.2 kB-73 B (-0.2%)

    • onMessage

      Size

      TypeBase (beaa4df)Merge (3c5ce6d)Diff
      size12.4 kB12.3 kB-72 B (-0.6%)
      size-with-ext-deps39.1 kB39.0 kB-73 B (-0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lAsNMyWB2o.html

@zwu52 zwu52 merged commit d6fa588 into main Sep 30, 2024
35 checks passed
@zwu52 zwu52 deleted the update_logging branch September 30, 2024 23:05
@google-oss-bot google-oss-bot mentioned this pull request Oct 8, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zwu52 @google-oss-bot @hsubox76