-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vertex GA] Rewrite Schema #8479
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2a16ff5
start work on Schema rewrite
hsubox76 ded26b7
fill out Schema builder
hsubox76 b14737f
Update API reports
hsubox76 2dd7a8f
refine design
hsubox76 11756ee
space
hsubox76 60afb6a
Merge branch 'ch-schema' of https://github.com/firebase/firebase-js-s…
hsubox76 f679066
Add some test cases, fix error
hsubox76 7b018bd
Update API reports
hsubox76 b79a7e2
Update doc comments
hsubox76 2f17c17
More fixes to doc comments
hsubox76 db629b1
Fixes based on testing
hsubox76 e4beaf5
merge
hsubox76 b57febe
fix error class
hsubox76 ad4935b
format
hsubox76 5dadea5
Update API reports
hsubox76 9cec6ea
Allow raw json in responseSchema
hsubox76 08ccd4b
set SchemaShared to public
hsubox76 fed48f8
Merge branch 'ch-schema' of https://github.com/firebase/firebase-js-s…
hsubox76 9d327c9
Merge branch 'v11' into ch-schema
hsubox76 442a708
fix docs
hsubox76 f5f2a48
Merge branch 'v11' into ch-schema
hsubox76 e28f20a
Merge branch 'v11' into ch-schema
hsubox76 e40e9cf
revert docs
hsubox76 bd64869
remove other added docs
hsubox76 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I know I reviewed this already, but is there a reason that this isn't readonly anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good question, I was going to mention it in the description. If it's readonly it can't be overwritten by super() which was causing some unexpected behavior. super() at the bottom of the constructor sets
message
to fullMessage (adds the service name and code) but it simply won't do anything if it's readonly. The next question would be, what aboutcode
- it's ok for code to not be overwritten with fullCode because adding the prefix just makes it harder to compare (e.g.error.code === VertexAIErrorCode.SOME_CODE
). The formattedfullCode
. only needs to go into the message.