Revert introduction of safevalues #8395

dlarocque · 2024-07-25T19:52:18Z

This reverts commit f58d48c.

An issue in App Check revealed that safevalues is not compatible with es5, since template tag functions are required, and those are not supported in es5. Our bundler tries to compensate for this by replacing template tag functions with tslib.__makeTemplateObject, but safevalues does not assert that those are valid template string literals, and throws an error.

This can be fixed by upgrading all of our browser cjs bundles from es5 to es6, but we don't want to make that breaking change at this time, so we must revert our usage of safevalues until we're ready to drop es5 support.

For more details, see #8386 (comment)

…8301)" This reverts commit f58d48c.

changeset-bot · 2024-07-25T19:52:22Z

🦋 Changeset detected

Latest commit: 2e00374

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@firebase/analytics	Patch
@firebase/app-check	Patch
@firebase/analytics-compat	Patch
firebase	Patch
@firebase/app-check-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-07-25T20:00:14Z

Changeset File Check ⚠️

Warning: This PR modifies files in the following packages but they have not been included in the changeset file:%0A - @firebase/auth%0A - @firebase/database-compat%0A - @firebase/database%0A - @firebase/messaging%0A%0A Make sure this was intentional.

google-oss-bot · 2024-07-25T20:07:30Z

Size Report ¹

Affected Products

@firebase/analytics
Type Base (e542f1d) Merge (d717de4) Diff
browser 21.3 kB 21.8 kB +531 B (+2.5%)
esm5 26.6 kB 27.0 kB +386 B (+1.5%)
main 28.1 kB 28.4 kB +351 B (+1.3%)
module 21.3 kB 21.8 kB +531 B (+2.5%)
@firebase/app-check
Type Base (e542f1d) Merge (d717de4) Diff
browser 26.4 kB 26.3 kB -64 B (-0.2%)
esm5 31.9 kB 31.6 kB -348 B (-1.1%)
main 33.2 kB 32.8 kB -404 B (-1.2%)
module 26.4 kB 26.3 kB -64 B (-0.2%)

`bundle`

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
analytics (logEvent)	48.3 kB	44.5 kB	-3.82 kB (-7.9%)
app-check (ReCaptchaEnterpriseProvider)	44.0 kB	39.9 kB	-4.09 kB (-9.3%)
app-check (ReCaptchaV3Provider)	43.9 kB	39.8 kB	-4.09 kB (-9.3%)

`firebase`

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
firebase-analytics-compat.js	29.9 kB	26.5 kB	-3.41 kB (-11.4%)
firebase-analytics.js	33.7 kB	29.7 kB	-4.01 kB (-11.9%)
firebase-app-check-compat.js	27.0 kB	23.4 kB	-3.67 kB (-13.6%)
firebase-app-check.js	29.4 kB	25.0 kB	-4.40 kB (-15.0%)
firebase-compat.js	789 kB	786 kB	-3.38 kB (-0.4%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/XtE2EyUOeQ.html

google-oss-bot · 2024-07-25T20:20:57Z

Size Analysis Report ¹

Affected Products

`@firebase/analytics`

`getAnalytics`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.4 kB	10.6 kB	+190 B (+1.8%)
size-with-ext-deps	48.2 kB	44.4 kB	-3.82 kB (-7.9%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

23 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getAnalytics
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
initializeAnalytics
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

25 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getAnalytics
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
initializeAnalytics
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`getGoogleAnalyticsClientId`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.3 kB	10.5 kB	+190 B (+1.9%)
size-with-ext-deps	41.0 kB	37.2 kB	-3.82 kB (-9.3%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

23 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getGoogleAnalyticsClientId
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
internalGetGoogleAnalyticsClientId
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

25 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getGoogleAnalyticsClientId
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
internalGetGoogleAnalyticsClientId
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`initializeAnalytics`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.3 kB	10.5 kB	+190 B (+1.8%)
size-with-ext-deps	41.3 kB	37.5 kB	-3.82 kB (-9.2%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

22 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
initializeAnalytics
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

24 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
initializeAnalytics
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`isSupported`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.2 kB	10.4 kB	+190 B (+1.9%)
size-with-ext-deps	40.9 kB	37.1 kB	-3.82 kB (-9.3%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

22 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
isSupported
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

24 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
isSupported
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`logEvent`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.0 kB	10.2 kB	+190 B (+1.9%)
size-with-ext-deps	40.8 kB	37.0 kB	-3.82 kB (-9.4%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

21 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

23 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`setAnalyticsCollectionEnabled`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.2 kB	10.4 kB	+190 B (+1.9%)
size-with-ext-deps	40.9 kB	37.1 kB	-3.82 kB (-9.3%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

23 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setAnalyticsCollectionEnabled
setAnalyticsCollectionEnabled$1
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

25 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setAnalyticsCollectionEnabled
setAnalyticsCollectionEnabled$1
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`setConsent`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.2 kB	10.4 kB	+190 B (+1.9%)
size-with-ext-deps	40.9 kB	37.1 kB	-3.82 kB (-9.3%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

23 dependencies

_initializeAnalytics
_setConsentDefaultForInit
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setConsent
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

25 dependencies

_initializeAnalytics
_setConsentDefaultForInit
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setConsent
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`setCurrentScreen`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.3 kB	10.5 kB	+190 B (+1.8%)
size-with-ext-deps	41.0 kB	37.2 kB	-3.82 kB (-9.3%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

23 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setCurrentScreen
setCurrentScreen$1
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

25 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setCurrentScreen
setCurrentScreen$1
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`setDefaultEventParameters`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.2 kB	10.4 kB	+190 B (+1.9%)
size-with-ext-deps	40.9 kB	37.1 kB	-3.82 kB (-9.3%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

23 dependencies

_initializeAnalytics
_setDefaultEventParametersForInit
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setDefaultEventParameters
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

25 dependencies

_initializeAnalytics
_setDefaultEventParametersForInit
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setDefaultEventParameters
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`setUserId`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.3 kB	10.5 kB	+190 B (+1.8%)
size-with-ext-deps	41.0 kB	37.2 kB	-3.82 kB (-9.3%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

23 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setUserId
setUserId$1
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

25 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setUserId
setUserId$1
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`setUserProperties`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.4 kB	10.5 kB	+190 B (+1.8%)
size-with-ext-deps	41.1 kB	37.3 kB	-3.82 kB (-9.3%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

23 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setUserProperties
setUserProperties$1
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

25 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
setUserProperties
setUserProperties$1
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`settings`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	10.2 kB	10.4 kB	+190 B (+1.9%)
size-with-ext-deps	40.9 kB	37.1 kB	-3.82 kB (-9.3%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

functions

22 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
settings
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

24 dependencies

_initializeAnalytics
attemptFetchDynamicConfigWithRetry
createGtagTrustedTypesScriptURL
createTrustedTypesPolicy
factory
fetchDynamicConfig
fetchDynamicConfigWithRetry
findGtagScriptOnPage
getHeaders
getOrCreateDataLayer
gtagOnConfig
gtagOnEvent
insertScriptTag
isRetriableError
logEvent
logEvent$1
promiseAllSettled
registerAnalytics
setAbortableTimeout
settings
validateIndexedDB
warnOnBrowserContextMismatch
wrapGtag
wrapOrCreateGtag

+ createGtagTrustedTypesScriptURL
+ createTrustedTypesPolicy

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`@firebase/app-check`

CustomProvider
Size
Type Base (e542f1d) Merge (d717de4) Diff
size 7.76 kB 7.72 kB -42 B (-0.5%)

`ReCaptchaEnterpriseProvider`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	11.5 kB	11.4 kB	-93 B (-0.8%)
size-with-ext-deps	33.8 kB	29.7 kB	-4.09 kB (-12.1%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

variables

18 dependencies

APP_CHECK_NAME
APP_CHECK_NAME_INTERNAL
APP_CHECK_STATES
BASE_ENDPOINT
DB_NAME
DB_VERSION
DEFAULT_STATE
ERRORS
ERROR_FACTORY
EXCHANGE_RECAPTCHA_ENTERPRISE_TOKEN_METHOD
ONE_DAY
STORE_NAME
TOKEN_REFRESH_TIME
dbPromise
defaultTokenErrorData
logger
name
version

19 dependencies

APP_CHECK_NAME
APP_CHECK_NAME_INTERNAL
APP_CHECK_STATES
BASE_ENDPOINT
DB_NAME
DB_VERSION
DEFAULT_STATE
ERRORS
ERROR_FACTORY
EXCHANGE_RECAPTCHA_ENTERPRISE_TOKEN_METHOD
ONE_DAY
RECAPTCHA_ENTERPRISE_URL
STORE_NAME
TOKEN_REFRESH_TIME
dbPromise
defaultTokenErrorData
logger
name
version

+ RECAPTCHA_ENTERPRISE_URL

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

`ReCaptchaV3Provider`

Size

Type	Base (`e542f1d`)	Merge (`d717de4`)	Diff
size	11.5 kB	11.4 kB	-93 B (-0.8%)
size-with-ext-deps	33.7 kB	29.7 kB	-4.09 kB (-12.1%)

Dependency

Type Base (e542f1d) Merge (d717de4) Diff

variables

18 dependencies

APP_CHECK_NAME
APP_CHECK_NAME_INTERNAL
APP_CHECK_STATES
BASE_ENDPOINT
DB_NAME
DB_VERSION
DEFAULT_STATE
ERRORS
ERROR_FACTORY
EXCHANGE_RECAPTCHA_TOKEN_METHOD
ONE_DAY
STORE_NAME
TOKEN_REFRESH_TIME
dbPromise
defaultTokenErrorData
logger
name
version

19 dependencies

APP_CHECK_NAME
APP_CHECK_NAME_INTERNAL
APP_CHECK_STATES
BASE_ENDPOINT
DB_NAME
DB_VERSION
DEFAULT_STATE
ERRORS
ERROR_FACTORY
EXCHANGE_RECAPTCHA_TOKEN_METHOD
ONE_DAY
RECAPTCHA_URL
STORE_NAME
TOKEN_REFRESH_TIME
dbPromise
defaultTokenErrorData
logger
name
version

+ RECAPTCHA_URL

External Dependency

Module	Base (`e542f1d`)	Merge (`d717de4`)	Diff
`safevalues`	trustedResourceUrl		- trustedResourceUrl
`safevalues/dom`	safeScriptEl		- safeScriptEl

getLimitedUseToken
Size
Type Base (e542f1d) Merge (d717de4) Diff
size 7.34 kB 7.29 kB -42 B (-0.6%)
getToken
Size
Type Base (e542f1d) Merge (d717de4) Diff
size 7.39 kB 7.35 kB -42 B (-0.6%)
initializeAppCheck
Size
Type Base (e542f1d) Merge (d717de4) Diff
size 11.3 kB 11.2 kB -42 B (-0.4%)
onTokenChanged
Size
Type Base (e542f1d) Merge (d717de4) Diff
size 7.49 kB 7.44 kB -42 B (-0.6%)
setTokenAutoRefreshEnabled
Size
Type Base (e542f1d) Merge (d717de4) Diff
size 7.48 kB 7.44 kB -42 B (-0.6%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ypFdC2ATPV.html

Revert "Use safevalues to fix trusted types issues reported by tsec (#…

9ddacba

…8301)" This reverts commit f58d48c.

dlarocque requested review from hsubox76, a team, lisajian, Xiaoshouzi-gh, sam-gc, zwu52, maneesht and aashishpatil-g as code owners July 25, 2024 19:52

Add Changeset

2e00374

dlarocque requested review from a team as code owners July 25, 2024 19:58

hsubox76 approved these changes Jul 25, 2024

View reviewed changes

dlarocque merged commit a9f8440 into master Jul 26, 2024
43 checks passed

dlarocque deleted the dlarocque/revert-safevalues branch July 26, 2024 18:38

This was referenced Jul 29, 2024

Safevalues TypeError in Jest Test #8386

Closed

Use safevalues to fix trusted types issues reported by tsec #8301

Merged

google-oss-bot mentioned this pull request Jul 30, 2024

Version Packages #8404

Merged

zntb mentioned this pull request Aug 22, 2024

[Snyk] Upgrade firebase from 10.11.0 to 10.12.5 zntb/ReduxCart#10

Merged

surajit03 mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.1.0 to 10.12.5 surajit03/accounting#200

Open

zntb mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.12.4 to 10.12.5 zntb/house-marketplace#8

Merged

kushalsdesk mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.4.0 to 10.12.5 kushalsdesk/Operax-front#57

Open

Tech-FestivalDoJapao mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.12.4 to 10.12.5 Tech-FestivalDoJapao/Gerenciamento#23

Merged

DevJPCosta mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.4.0 to 10.12.5 DevJPCosta/EienOtakuv1#25

Open

leoo1992 mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.12.4 to 10.12.5 leoo1992/next-tailwind-firebase#26

Merged

anthoniorico mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.12.4 to 10.12.5 anthoniorico/Exam-Capstone-Project#8

Open

lydmoon mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.5.2 to 10.12.5 lydmoon/Lydia-MoonFullStackBankingApplication#63

Open

Abellache-Rabah mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.0.0 to 10.12.5 Abellache-Rabah/backend-hawasli#57

Open

arnonrdp mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.12.2 to 10.12.5 arnonrdp/LivroLog#1047

Closed

sswietoniowski mentioned this pull request Aug 23, 2024

[Snyk] Upgrade firebase from 10.12.4 to 10.12.5 sswietoniowski/learning-html-css-javascript#424

Merged

Abellache-Rabah mentioned this pull request Aug 24, 2024

[Snyk] Upgrade firebase from 10.0.0 to 10.12.5 Abellache-Rabah/backend-hawasli#58

Open

kenn7575 mentioned this pull request Aug 24, 2024

[Snyk] Upgrade firebase from 10.12.4 to 10.12.5 kenn7575/kenni-kollemorten-v2#67

Merged

Harshu0132 mentioned this pull request Aug 24, 2024

[Snyk] Upgrade firebase from 10.12.4 to 10.12.5 Harshu0132/Netflix-Gemini#3

Open

NEONKID mentioned this pull request Aug 25, 2024

[Snyk] Upgrade firebase from 8.10.1 to 10.12.5 NEONKID/Portpolio-web#335

Open

Nkazi01 mentioned this pull request Aug 25, 2024

[Snyk] Upgrade firebase from 10.12.4 to 10.12.5 Nkazi01/Registrar#2

Open

firebase locked and limited conversation to collaborators Aug 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert introduction of safevalues #8395

Revert introduction of safevalues #8395

dlarocque commented Jul 25, 2024

changeset-bot bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024

google-oss-bot commented Jul 25, 2024 •

edited

Loading

`@firebase/analytics`

`@firebase/app-check`

`bundle`

`firebase`

google-oss-bot commented Jul 25, 2024 •

edited

Loading

`@firebase/analytics`

`getAnalytics`

`getGoogleAnalyticsClientId`

`initializeAnalytics`

`isSupported`

`logEvent`

`setAnalyticsCollectionEnabled`

`setConsent`

`setCurrentScreen`

`setDefaultEventParameters`

`setUserId`

`setUserProperties`

`settings`

`@firebase/app-check`

`CustomProvider`

`ReCaptchaEnterpriseProvider`

`ReCaptchaV3Provider`

`getLimitedUseToken`

`getToken`

`initializeAppCheck`

`onTokenChanged`

`setTokenAutoRefreshEnabled`

Revert introduction of safevalues #8395

Revert introduction of safevalues #8395

Conversation

dlarocque commented Jul 25, 2024

changeset-bot bot commented Jul 25, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Jul 25, 2024

Changeset File Check ⚠️

google-oss-bot commented Jul 25, 2024 • edited Loading

Size Report 1

Affected Products

@firebase/analytics

@firebase/app-check

bundle

firebase

Test Logs

google-oss-bot commented Jul 25, 2024 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/analytics

getAnalytics

getGoogleAnalyticsClientId

initializeAnalytics

isSupported

logEvent

setAnalyticsCollectionEnabled

setConsent

setCurrentScreen

setDefaultEventParameters

setUserId

setUserProperties

settings

@firebase/app-check

CustomProvider

ReCaptchaEnterpriseProvider

ReCaptchaV3Provider

getLimitedUseToken

getToken

initializeAppCheck

onTokenChanged

setTokenAutoRefreshEnabled

Test Logs

changeset-bot bot commented Jul 25, 2024 •

edited

Loading

google-oss-bot commented Jul 25, 2024 •

edited

Loading

Size Report ¹

`@firebase/analytics`

`@firebase/app-check`

`bundle`

`firebase`

google-oss-bot commented Jul 25, 2024 •

edited

Loading

Size Analysis Report ¹

`@firebase/analytics`

`getAnalytics`

`getGoogleAnalyticsClientId`

`initializeAnalytics`

`isSupported`

`logEvent`

`setAnalyticsCollectionEnabled`

`setConsent`

`setCurrentScreen`

`setDefaultEventParameters`

`setUserId`

`setUserProperties`

`settings`

`@firebase/app-check`

`CustomProvider`

`ReCaptchaEnterpriseProvider`

`ReCaptchaV3Provider`

`getLimitedUseToken`

`getToken`

`initializeAppCheck`

`onTokenChanged`

`setTokenAutoRefreshEnabled`