Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VertexAI: add test script to run unit tests without updating mock responses #8342

Merged
merged 2 commits into from
Jul 2, 2024
Merged

VertexAI: add test script to run unit tests without updating mock responses #8342

merged 2 commits into from
Jul 2, 2024

Conversation

tanzimfh
Copy link
Contributor

This adds a new script in the vertexai package that runs unit tests without updating mock responses.

@tanzimfh tanzimfh requested a review from dlarocque June 28, 2024 17:24
@tanzimfh tanzimfh requested a review from a team as a code owner June 28, 2024 17:24
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f4cd7a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tanzimfh tanzimfh force-pushed the tanzim/debug-script branch from 9ac42d1 to 2e9bd88 Compare June 28, 2024 22:17
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 28, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (ed1c993) and merge commit (fdd8bbe).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2vugZP9Gaa.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 28, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (ed1c993) and merge commit (fdd8bbe).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/If7pGkrDvP.html

dlarocque
dlarocque reviewed Jul 2, 2024
View reviewed changes
packages/vertexai/package.json Outdated
@@ -37,6 +37,7 @@
"testsetup": "yarn update-responses && yarn ts-node ./test-utils/convert-mocks.ts",
"test": "run-p --npm-path npm lint test:browser",
"test:ci": "yarn testsetup && node ../../scripts/run_tests_in_ci.js -s test",
"test:debug": "karma start --single-run",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that :debug is misleading since we are not enabling debugging capabilities, and instead just skip the re-clone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. How about :skip-clone?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that would be clearer

@tanzimfh tanzimfh changed the title VertexAI: add test:debug script VertexAI: add test script to run unit tests without updating mock responses Jul 2, 2024
@dlarocque dlarocque self-requested a review July 2, 2024 15:09
@tanzimfh tanzimfh merged commit c60aac1 into master Jul 2, 2024
34 checks passed
@tanzimfh tanzimfh deleted the tanzim/debug-script branch July 2, 2024 16:23
tom-andersen pushed a commit that referenced this pull request Jul 24, 2024
@tanzimfh @tom-andersen
VertexAI: add test script to run unit tests without updating mock res…
0b70923 
…ponses (#8342)
@firebase firebase locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dlarocque dlarocque dlarocque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanzimfh @google-oss-bot @dlarocque