Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix a typo in the webchannel-wrapper's package.json. #8331

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: Fix a typo in the webchannel-wrapper's package.json. #8331

merged 2 commits into from
Jun 24, 2024

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Jun 21, 2024 •
edited
Loading

Fixes a typo in the webchannel-wrapper's package.json that affected ems5 exports.

@ehsannas ehsannas requested a review from hsubox76 June 21, 2024 20:52
@ehsannas ehsannas requested review from a team as code owners June 21, 2024 20:52
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 082337f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/webchannel-wrapper Patch
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ehsannas ehsannas mentioned this pull request Jun 21, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 21, 2024 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 21, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (ca41391) and merge commit (fb03103).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mQbjuWIgBE.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 21, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (ca41391) and merge commit (fb03103).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Uzf98oWVDI.html

DellaBitta
DellaBitta requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset with the public release note. Thanks!

@ehsannas ehsannas requested a review from a team as a code owner June 24, 2024 18:16
@ehsannas ehsannas requested a review from DellaBitta June 24, 2024 18:17
DellaBitta
DellaBitta approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a PR description. Could be the same text as the changeset. Thanks!

@ehsannas
Copy link
Contributor Author

Done.

@ehsannas ehsannas merged commit b09a267 into master Jun 24, 2024
42 checks passed
@ehsannas ehsannas deleted the ehsann/fix-webchannel-wrapper-typo branch June 24, 2024 20:36
@google-oss-bot google-oss-bot mentioned this pull request Jul 2, 2024
Merged
dconeybe
dconeybe reviewed Jul 8, 2024
View reviewed changes
.changeset/orange-rings-own.md
"@firebase/webchannel-wrapper": patch
---

fix: Fix a typo in the webchannel-wrapper's package.json that affected ems5 exports.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by comment: there is a typo in the release notes: "ems5" should be "esm5". That is proving to be a difficult acronym to spell correctly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsannas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch :(

It seems that this doesn't show up on the release notes (https://firebase.google.com/support/release-notes/js) page though (because it's a webchannel-wrapper package change?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure about webchannel-wrapper release notes showing up. Maybe they're not included, but, rather, expect to be mentioned by the dependents upgrading their dependency (i.e. a Firestore change that has its own release note that goes with the webchanne-wrapper upgrade).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I wrote the release notes for the 10.12.3 release where this went out. I mistakingly excluded this from the release notes. Looking at older release notes, we list changes to webchannel-wrapper under Firestore.

Sorry if I caused any confusion- I'll create a CL to mention this change in the release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix the typo in your CL then. Thanks @dlarocque.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add me as reviewer for your CL. Thanks :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add me as reviewer for your CL. Thanks :)

Sounds good. I added you as a reviewer

tom-andersen pushed a commit that referenced this pull request Jul 24, 2024
@ehsannas @tom-andersen
fix: Fix a typo in the webchannel-wrapper's package.json. (#8331)
9c18bf8 
* fix: Fix a typo in the webchannel-wrapper's package.json.

* Create orange-rings-own.md
@firebase firebase locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dlarocque dlarocque dlarocque left review comments

@dconeybe dconeybe dconeybe left review comments

@DellaBitta DellaBitta DellaBitta approved these changes

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@DellaBitta DellaBitta

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ehsannas @google-oss-bot @DellaBitta @dconeybe @dlarocque @hsubox76