More robust clean up after unexpected docgen process exits. #8260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temp/
json dir before every run.The cleanup process used to run in a "finally" block which is fine for catching errors caused by the specific code but doesn't account for a SIGINT or some other unexpected interruption.
I think I put enough checks in the cleanup code to make sure the steps don't error but I also wrapped it in a try/catch just in case with a warning to watch out for changed files.