Mikelehen/doc changes for each #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 15, 2018 15:29
…ept on QuerySnapshot.docChanges.
mikelehen
requested review from
jshcrowthe,
schmidt-sebastian and
wilhuff
as code owners
schmidt-sebastian
approved these changes
May 15, 2018
| ]; | ||
| docChangesPropertiesToOverride.forEach(property => { | ||
| /** | ||
| * This will technically overwrite the `Function.prototype.length` property of |
There was a problem hiding this comment.
Can you update the comment to indicate that "this" indicates "overwriting length".
There was a problem hiding this comment.
Thanks, I rewrote the comment to hopefully be clearer:
/**
* We are (re-)defining properties on QuerySnapshot.prototype.docChanges which
* is a Function. This could fail, in particular in the case of 'length' which
* already exists on Function.prototype and on IE11 is improperly defined with
* `{ configurable: false }`. So we wrap this in a try/catch to ensure that we
* still have a functional SDK.
*/
I'll hold off on trying to submit this until you make the publishToNpm() style thing go away.
There was a problem hiding this comment.
Thanks. I like it a lot!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'forEach' (and 'map' for good measure) to Array methods we intercept on QuerySnapshot.docChanges.
Would have prevented #824.