Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest published version for auth sample app #8130

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

renkelvin
Copy link

@renkelvin renkelvin commented Apr 5, 2024

Upgrade the sample app build file so that the latest published Firebase libs are for auth sample app.

@renkelvin renkelvin requested review from lisajian, Xiaoshouzi-gh, sam-gc and a team as code owners April 5, 2024 19:44
Copy link

changeset-bot bot commented Apr 5, 2024

⚠️ No Changeset found

Latest commit: 4b6e286

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@renkelvin renkelvin requested a review from NhienLam April 8, 2024 21:28
Copy link

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DellaBitta
Copy link
Contributor

Could you please add a PR description?

@renkelvin
Copy link
Author

Could you please add a PR description?

Added, it's similar to the title though.

@renkelvin
Copy link
Author

Could you please add a PR description?

@DellaBitta Btw, do you know if the Firestore CI failures can be ignored?

@DellaBitta
Copy link
Contributor

Could you please add a PR description?

@DellaBitta Btw, do you know if the Firestore CI failures can be ignored?

we can re-run them.

@renkelvin renkelvin merged commit 9297ef3 into master Apr 9, 2024
44 checks passed
@renkelvin renkelvin deleted the sample-dep branch April 9, 2024 17:22
@firebase firebase locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants