Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue where queryConstraint.type was undefined #7973

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Fixed issue where queryConstraint.type was undefined #7973

merged 3 commits into from
Jan 23, 2024

Conversation

maneesht
Copy link
Contributor

Fixes #7835. Originally, we set the type of type to be a string, but that didn't actually set the value of the property (s/:/=)

@maneesht maneesht requested review from jmwski and a team as code owners January 23, 2024 00:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1f4a374

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/database Patch
@firebase/database-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maneesht maneesht requested review from a team as code owners January 23, 2024 00:38
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 23, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/database

    TypeBase (9ea0e3b)Merge (400efa0)Diff
    browser248 kB249 kB+355 B (+0.1%)
    esm5277 kB277 kB+312 B (+0.1%)
    main282 kB282 kB+312 B (+0.1%)
    module248 kB249 kB+355 B (+0.1%)

  • @firebase/database-compat/standalone

    TypeBase (9ea0e3b)Merge (400efa0)Diff
    main371 kB372 kB+312 B (+0.1%)

  • bundle

    TypeBase (9ea0e3b)Merge (400efa0)Diff
    database (Filtering data)147 kB147 kB+24 B (+0.0%)
    database (Sort data)149 kB149 kB+25 B (+0.0%)

  • firebase

    TypeBase (9ea0e3b)Merge (400efa0)Diff
    firebase-compat.js779 kB780 kB+355 B (+0.0%)
    firebase-database-compat.js166 kB166 kB+355 B (+0.2%)
    firebase-database.js186 kB186 kB+355 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0AF4PUvkkT.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 23, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/database

    • endAt

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size118 kB118 kB+18 B (+0.0%)
      size-with-ext-deps140 kB140 kB+18 B (+0.0%)

    • endBefore

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size118 kB118 kB+22 B (+0.0%)
      size-with-ext-deps140 kB140 kB+22 B (+0.0%)

    • equalTo

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size119 kB119 kB+58 B (+0.0%)
      size-with-ext-deps141 kB141 kB+58 B (+0.0%)

    • limitToFirst

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size116 kB116 kB+25 B (+0.0%)
      size-with-ext-deps138 kB138 kB+25 B (+0.0%)

    • limitToLast

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size116 kB116 kB+24 B (+0.0%)
      size-with-ext-deps138 kB138 kB+24 B (+0.0%)

    • orderByChild

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size118 kB118 kB+25 B (+0.0%)
      size-with-ext-deps140 kB140 kB+25 B (+0.0%)

    • orderByKey

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size117 kB117 kB+57 B (+0.0%)
      size-with-ext-deps139 kB139 kB+57 B (+0.0%)

    • orderByPriority

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size117 kB117 kB+62 B (+0.1%)
      size-with-ext-deps139 kB139 kB+62 B (+0.0%)

    • orderByValue

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size117 kB117 kB+59 B (+0.1%)
      size-with-ext-deps139 kB139 kB+59 B (+0.0%)

    • startAfter

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size118 kB118 kB+23 B (+0.0%)
      size-with-ext-deps140 kB140 kB+23 B (+0.0%)

    • startAt

      Size

      TypeBase (9ea0e3b)Merge (400efa0)Diff
      size118 kB118 kB+20 B (+0.0%)
      size-with-ext-deps140 kB140 kB+20 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Di3jCWj9kA.html

antholeole
antholeole approved these changes Jan 23, 2024
View reviewed changes
Copy link

@antholeole antholeole left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. And thx for the test!

@maneesht maneesht merged commit 046ac8a into master Jan 23, 2024
36 checks passed
@maneesht maneesht deleted the mtewani/fix-query-types branch January 23, 2024 19:29
@google-oss-bot google-oss-bot mentioned this pull request Jan 30, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

@antholeole antholeole antholeole approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@jmwski jmwski Awaiting requested review from jmwski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QueryConstraint's type can't be accessed
5 participants
@maneesht @google-oss-bot @hsubox76 @antholeole @aashishpatil-g