Add app-check-interop-types dependency to database #7827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5415ac1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hsubox76
requested review from
a team,
maneesht,
jsdt and
jmwski
as code owners
Size Report 1Affected ProductsNo changes between base commit (70e4cf6) and merge commit (8964150).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (70e4cf6) and merge commit (8964150).Test Logs |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An import of
@firebase/app-check-interop-typeswas added to the standalone entry points (consumed by admin-node) in #7258This dep wasn't getting installed when consumed by the admin-node package because admin-node only installs
@firebase/database-compatand not the umbrellafirebasepackage.In this PR the dep is being added in
@firebase/databasebut will be installed transitively asdatabase-compatdepends ondatabase. This is already working forauth-interop-types. We just need to addapp-check-interop-typesin the same place.