Make firestore-integration its own job in "test all" #7426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsNo changes between base commit (b58a617) and merge commit (0a3bf96).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (b58a617) and merge commit (0a3bf96).Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
We have required "test-changed" workflows that run on subsets of packages if they detect a file in that package has changed. We also had a non-required "test-all" workflow that runs all tests regardless of what changed. That workflow was extremely flaky so we recently split it into separate jobs to see if we could reduce flakiness: #7353
In that workflow we still kept firestore and firebase-firestore-integration-test tests grouped together, which may actually be causing a lot of the flakiness. Splitting them again into two separate jobs here.