Fix RTDB typings used by compat #7422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67dd5b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
maneesht
approved these changes
Jul 6, 2023
dconeybe
added a commit
that referenced
this pull request
Jul 6, 2023
dconeybe
added a commit
that referenced
this pull request
Jul 6, 2023
Size Report 1Affected ProductsNo changes between base commit (c29156a) and merge commit (c86e9ff).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (c29156a) and merge commit (c86e9ff).Test Logs |
allspain
approved these changes
Jul 6, 2023
dconeybe
changed the title
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Firestore changes will be done in a separate PR: #7423
E2E tests failed TypeScript compat build:
https://github.com/firebase/firebase-js-sdk/actions/runs/5470942751
due to changes on the following PRs:
Firestore PR: #7310RTDB PR: #6541
The E2E tests install the staged NPM version of the
firebasepackage and run some smoke tests. They failed on TypeScript compilation due to the following reasons:1) For Firestore, types were only updated in Firestore modular, which is expected, as we don't add new features to compat. However, compat wraps modular classes, and it ran into an error importing their types and then checking them against firestore-types, which it uses as its types package. I'm not sure why it uses firestore-types instead of importing types directly from@firebase/firestorebut that would be a future change. I did try it, but it's not a 1-to-1 correspondence, especially theFirebaseFirestoreinstance type, which doesn't exist in modular.