-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for the v9 implementation of UpdateData<T> #7319
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (039f05f) and merge commit (8fceac9).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (039f05f) and merge commit (8fceac9).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this test coverage! This is fantastic to reduce the risks of regression and definitely increases the confidence that #7318 works as expected.
…kduckworth/nested-update-data-v9
Tests in this PR are being added to ensure that UpdateData does not regress. These tests do not evaluate any JS implementation, they only evaluate TS types, therefore you do not see any meaningful expect statements in these tests. Type behavior is asserted during the TS compilation, if the tests do not build then the tests are failing.
Empty assertions
expect(true).to.be.true
are included to avoid possible flagging of tests that do not perform assertions.