firestore-compat: fix typing error of 'settings' object in fields.test.ts #7108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y 'ignoreUndefinedProperties' does not exist on type '{ host: string; ssl: boolean; }'
|
Size Report 1Affected ProductsNo changes between base commit (e0b677e) and merge commit (07d7bf7).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (e0b677e) and merge commit (07d7bf7).Test Logs |
renkelvin
pushed a commit
that referenced
this pull request
Mar 21, 2023
…y 'ignoreUndefinedProperties' does not exist on type '{ host: string; ssl: boolean; }' (#7108)
renkelvin
pushed a commit
that referenced
this pull request
Mar 21, 2023
…y 'ignoreUndefinedProperties' does not exist on type '{ host: string; ssl: boolean; }' (#7108)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some GitHub Actions, the
fields.test.tsfails TypeScript compilation due to the following error:e.g. https://github.com/firebase/firebase-js-sdk/actions/runs/4367447223/jobs/7638769445 (full logs: https://gist.github.com/dconeybe/85ad1521dea7123530d1c28424098367).
This PR fixes the error by constructing the
settingsobject in a single operation, rather than creating it with some default values, then adding a property to it.