Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting the changeset's version bump type. #7067

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Correcting the changeset's version bump type. #7067

merged 1 commit into from
Feb 28, 2023

Conversation

MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

⚠️ No Changeset found

Latest commit: b58a857

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore-compat Minor
@firebase/firestore Minor
firebase Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dwyfrequency
dwyfrequency approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (7150c78) and merge commit (3da562f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/s6UtUcp2BQ.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (7150c78) and merge commit (3da562f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dHFMMto37P.html

@MarkDuckworth MarkDuckworth merged commit 39c9ada into master Feb 28, 2023
@MarkDuckworth MarkDuckworth deleted the markduckworth/fix-changeset-heavy-starfishes-count branch February 28, 2023 23:50
renkelvin pushed a commit that referenced this pull request Mar 2, 2023
@MarkDuckworth
Correcting the changeset's version bump type. (#7067)
edc77ce
@firebase firebase locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkDuckworth @google-oss-bot @dwyfrequency