Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exports fields #7007

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Fix exports fields #7007

merged 2 commits into from
Feb 3, 2023

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Feb 3, 2023 •
edited
Loading

Move exports.defaults field to the last field.
Fixes #7005.

This bug was introduced by #6981.

PR based on #7006

Edit: tested locally with a Next.js project

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2023

🦋 Changeset detected

Latest commit: 675a556

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
@firebase/database Patch
@firebase/database-compat Patch
firebase Patch
@firebase/firestore Patch
@firebase/firestore-compat Patch
@firebase/functions Patch
@firebase/functions-compat Patch
@firebase/rules-unit-testing Patch
@firebase/storage Patch
@firebase/template Patch
@firebase/util Patch
@firebase/storage-compat Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/component Patch
@firebase/database-types Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review February 3, 2023 17:07
@hsubox76 hsubox76 changed the title Ch cjs fix Fix exports fields Feb 3, 2023
dwyfrequency
dwyfrequency approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maneesht
maneesht approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@maneesht maneesht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for database, database-compat and storage

@Timebutt Timebutt mentioned this pull request Feb 3, 2023
Closed
@hsubox76 hsubox76 merged commit d071bd1 into master Feb 3, 2023
@hsubox76 hsubox76 deleted the ch-cjs-fix branch February 3, 2023 17:41
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (3323f68) and merge commit (d4aaf40).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/M4TzMKnuqD.html

@google-oss-bot google-oss-bot mentioned this pull request Feb 3, 2023
Merged
@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (3323f68) and merge commit (d4aaf40).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XG1FTPoohE.html

@firebase firebase locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@maneesht maneesht maneesht approved these changes

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@avolkovi avolkovi Awaiting requested review from avolkovi

@sam-gc sam-gc Awaiting requested review from sam-gc

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

@lisajian lisajian Awaiting requested review from lisajian

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

@jsdt jsdt Awaiting requested review from jsdt

@jmwski jmwski Awaiting requested review from jmwski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module not found: Default condition should be last one
5 participants
@hsubox76 @google-oss-bot @lahirumaramba @maneesht @dwyfrequency