Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle IPv6 addresses in emulator autoinit. #6673

Merged
merged 6 commits into from
Oct 10, 2022
Merged

Handle IPv6 addresses in emulator autoinit. #6673

merged 6 commits into from
Oct 10, 2022

Conversation

yuchenshi
Copy link
Member

Fixes IPv6 addresses not parsed correctly in #6526. See tests added

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 5aa90e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/storage Patch
@firebase/util Patch
@firebase/database-compat Patch
firebase Patch
@firebase/firestore-compat Patch
@firebase/functions-compat Patch
@firebase/storage-compat Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/auth-compat Patch
@firebase/auth Patch
@firebase/component Patch
@firebase/database-types Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yuchenshi yuchenshi requested a review from egilmorez as a code owner October 10, 2022 19:46
maneesht
maneesht approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@maneesht maneesht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage/RTDB LGTM

hsubox76
hsubox76 reviewed Oct 10, 2022
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Just one comment on the tests.

packages/util/test/defaults.test.ts Outdated Show resolved Hide resolved
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 10, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/database

    TypeBase (1fbc4c4)Merge (a066717)Diff
    browser248 kB248 kB-62 B (-0.0%)
    esm5276 kB276 kB-49 B (-0.0%)
    main281 kB281 kB-54 B (-0.0%)
    module248 kB248 kB-62 B (-0.0%)

  • @firebase/firestore

    TypeBase (1fbc4c4)Merge (a066717)Diff
    browser266 kB266 kB-18 B (-0.0%)
    main531 kB531 kB-76 B (-0.0%)
    module266 kB266 kB-18 B (-0.0%)
    react-native266 kB266 kB-18 B (-0.0%)

  • @firebase/firestore-lite

    TypeBase (1fbc4c4)Merge (a066717)Diff
    browser82.2 kB82.2 kB-18 B (-0.0%)
    main139 kB139 kB-76 B (-0.1%)
    module82.2 kB82.2 kB-18 B (-0.0%)
    react-native82.4 kB82.4 kB-18 B (-0.0%)

  • @firebase/functions

    TypeBase (1fbc4c4)Merge (a066717)Diff
    browser9.62 kB9.55 kB-65 B (-0.7%)
    esm511.7 kB11.7 kB-36 B (-0.3%)
    main12.6 kB12.5 kB-55 B (-0.4%)
    module9.62 kB9.55 kB-65 B (-0.7%)

  • @firebase/storage

    TypeBase (1fbc4c4)Merge (a066717)Diff
    browser55.6 kB55.5 kB-59 B (-0.1%)
    esm561.8 kB61.8 kB-44 B (-0.1%)
    main58.4 kB58.4 kB-70 B (-0.1%)
    module55.6 kB55.5 kB-59 B (-0.1%)

  • @firebase/util

    TypeBase (1fbc4c4)Merge (a066717)Diff
    browser22.0 kB22.6 kB+511 B (+2.3%)
    esm523.4 kB24.0 kB+512 B (+2.2%)
    main28.8 kB29.5 kB+674 B (+2.3%)
    module22.0 kB22.6 kB+511 B (+2.3%)

  • bundle

    30 size changes

    TypeBase (1fbc4c4)Merge (a066717)Diff
    database (Append to a list of data)147 kB148 kB+256 B (+0.2%)
    database (Filtering data)146 kB147 kB+256 B (+0.2%)
    database (Listen for child events)162 kB163 kB+256 B (+0.2%)
    database (Listen for value events + Detach listeners)162 kB163 kB+256 B (+0.2%)
    database (Listen for value events)162 kB163 kB+256 B (+0.2%)
    database (Read data once)162 kB162 kB+256 B (+0.2%)
    database (Save data as transactions)164 kB165 kB+256 B (+0.2%)
    database (Sort data)148 kB148 kB+256 B (+0.2%)
    database (Write data)147 kB147 kB+256 B (+0.2%)
    firestore (Persistence)276 kB276 kB+252 B (+0.1%)
    firestore (Query Cursors)213 kB213 kB+259 B (+0.1%)
    firestore (Query)214 kB214 kB+259 B (+0.1%)
    firestore (Read data once)202 kB202 kB+259 B (+0.1%)
    firestore (Realtime updates)204 kB204 kB+259 B (+0.1%)
    firestore (Transaction)186 kB186 kB+259 B (+0.1%)
    firestore (Write data)185 kB186 kB+259 B (+0.1%)
    firestore-lite (Query Cursors)71.0 kB71.3 kB+259 B (+0.4%)
    firestore-lite (Query)74.2 kB74.4 kB+259 B (+0.3%)
    firestore-lite (Read data once)58.6 kB58.8 kB+259 B (+0.4%)
    firestore-lite (Transaction)83.2 kB83.4 kB+259 B (+0.3%)
    firestore-lite (Write data)68.3 kB68.6 kB+259 B (+0.4%)
    functions (call)30.5 kB30.8 kB+258 B (+0.8%)
    storage (getBytes)39.7 kB39.9 kB+263 B (+0.7%)
    storage (getDownloadURL)41.8 kB42.0 kB+263 B (+0.6%)
    storage (getMetadata)41.2 kB41.5 kB+263 B (+0.6%)
    storage (list + listAll)40.6 kB40.9 kB+263 B (+0.6%)
    storage (updateMetadata)41.5 kB41.7 kB+263 B (+0.6%)
    storage (uploadBytes)46.0 kB46.3 kB+263 B (+0.6%)
    storage (uploadBytesResumable)55.9 kB56.1 kB+263 B (+0.5%)
    storage (uploadString)46.2 kB46.5 kB+263 B (+0.6%)

  • firebase

    TypeBase (1fbc4c4)Merge (a066717)Diff
    firebase-auth-react-native.js149 kB149 kB+296 B (+0.2%)
    firebase-database.js154 kB154 kB+245 B (+0.2%)
    firebase-firestore-lite.js88.6 kB88.8 kB+227 B (+0.3%)
    firebase-firestore.js314 kB314 kB+221 B (+0.1%)
    firebase-functions.js10.5 kB10.8 kB+226 B (+2.1%)
    firebase-storage.js38.1 kB38.3 kB+232 B (+0.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rLsQMxOPus.html

@yuchenshi yuchenshi merged commit 171b78b into master Oct 10, 2022
@yuchenshi yuchenshi deleted the ys/modular-autoinit-ipv6 branch October 10, 2022 20:31
@google-oss-bot google-oss-bot mentioned this pull request Oct 10, 2022
Merged
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 10, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/database

    • getDatabase

      Size

      TypeBase (1fbc4c4)Merge (2ed758e)Diff
      size116 kB116 kB-25 B (-0.0%)
      size-with-ext-deps145 kB145 kB+256 B (+0.2%)

      External Dependency

      ModuleBase (1fbc4c4)Merge (2ed758e)Diff
      @firebase/util

      25 dependencies

      Deferred
Sha1
assert
assertionError
base64
base64Encode
contains
createMockUserToken
deepCopy
errorPrefix
getDefaultEmulatorHost
getModularInstance
isAdmin
isEmpty
isMobileCordova
isNodeSdk
isReactNative
isValidFormat
jsonEval
map
querystring
safeGet
stringLength
stringToByteArray
stringify

      25 dependencies

      Deferred
Sha1
assert
assertionError
base64
base64Encode
contains
createMockUserToken
deepCopy
errorPrefix
getDefaultEmulatorHostnameAndPort
getModularInstance
isAdmin
isEmpty
isMobileCordova
isNodeSdk
isReactNative
isValidFormat
jsonEval
map
querystring
safeGet
stringLength
stringToByteArray
stringify

      + getDefaultEmulatorHostnameAndPort
- getDefaultEmulatorHost

  • @firebase/firestore

    • getFirestore

      Size

      TypeBase (1fbc4c4)Merge (2ed758e)Diff
      size18.5 kB18.4 kB-29 B (-0.2%)
      size-with-ext-deps85.0 kB85.3 kB+254 B (+0.3%)

      External Dependency

      ModuleBase (1fbc4c4)Merge (2ed758e)Diff
      @firebase/util

      FirebaseError
createMockUserToken
getDefaultEmulatorHost

      FirebaseError
createMockUserToken
getDefaultEmulatorHostnameAndPort

      + getDefaultEmulatorHostnameAndPort
- getDefaultEmulatorHost

  • @firebase/functions

    • getFunctions

      Size

      TypeBase (1fbc4c4)Merge (2ed758e)Diff
      size2.63 kB2.60 kB-25 B (-1.0%)
      size-with-ext-deps26.7 kB27.0 kB+258 B (+1.0%)

      External Dependency

      ModuleBase (1fbc4c4)Merge (2ed758e)Diff
      @firebase/util

      getDefaultEmulatorHost
getModularInstance

      getDefaultEmulatorHostnameAndPort
getModularInstance

      + getDefaultEmulatorHostnameAndPort
- getDefaultEmulatorHost

  • @firebase/storage

    • getStorage

      Size

      TypeBase (1fbc4c4)Merge (2ed758e)Diff
      size10.5 kB10.5 kB-25 B (-0.2%)
      size-with-ext-deps35.3 kB35.5 kB+263 B (+0.7%)

      External Dependency

      ModuleBase (1fbc4c4)Merge (2ed758e)Diff
      @firebase/util

      FirebaseError
createMockUserToken
getDefaultEmulatorHost
getModularInstance

      FirebaseError
createMockUserToken
getDefaultEmulatorHostnameAndPort
getModularInstance

      + getDefaultEmulatorHostnameAndPort
- getDefaultEmulatorHost

  • @firebase/util

    • getDefaultEmulatorHostnameAndPort

      Size

      TypeBase (1fbc4c4)Merge (2ed758e)Diff
      size?4.14 kB? (?)
      size-with-ext-deps?4.14 kB? (?)

      Dependency

      TypeBase (1fbc4c4)Merge (2ed758e)Diff
      functions?

      getGlobal

      		?
      classes??
      variables?

      base64
base64Decode
byteArrayToString
getDefaultEmulatorHost
getDefaultEmulatorHostnameAndPort
getDefaults
getDefaultsFromCookie
getDefaultsFromEnvVariable
getDefaultsFromGlobal
stringToByteArray$1

      		?
      enums??

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EP88u9y8OH.html

@github-actions github-actions bot added the doc-changes PRs that affect docs label Oct 10, 2022
@firebase firebase locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@maneesht maneesht maneesht approved these changes

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

@jsdt jsdt Awaiting requested review from jsdt

@jmwski jmwski Awaiting requested review from jmwski

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@egilmorez egilmorez

@hsubox76 hsubox76

Labels
doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuchenshi @google-oss-bot @maneesht @hsubox76 @egilmorez