-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modular autoinit breakage #6663
Conversation
I ran into this issue updating dependencies for a Nuxt 3 app. The problem is that `process.{client,server,dev}` are defined even on the client, so the client ends up broken with errors like: ``` Uncaught TypeError: can't access property "__FIREBASE_DEFAULTS__", process.env is undefined ``` Since the code only uses `process.env`, this updates the check to look explicitly for `process.env`.
|
Thank you! Can you add a changeset for |
Should be all set, updated |
Thanks! Just fyi, we use But it turns out I also have to make other fixes in that file due to #6660 so I can just put this fix in the same PR so we won't run into any merge conflicts or anything and you don't have to worry about the changeset tool. |
Rolling this fix into #6665 |
Sounds good to me, and sorry for glossing over the (very clearly laid out) instructions! |
I ran into this issue updating dependencies for a Nuxt 3 app. The problem is that
process.{client,server,dev}
are defined even on the client, so the client ends up broken with errors like:Since the code only uses
process.env
, this updates the check to look explicitly forprocess.env
.Fixes #6662