Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make index beta #6510

Merged
merged 7 commits into from
Aug 6, 2022
Merged

Make index beta #6510

merged 7 commits into from
Aug 6, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Aug 5, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2022

⚠️ No Changeset found

Latest commit: f37af18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 5, 2022

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (a80e29c)Merge (11fbce0)Diff
    browser264 kB264 kB+170 B (+0.1%)
    esm5327 kB327 kB+295 B (+0.1%)
    main525 kB525 kB+446 B (+0.1%)
    module264 kB264 kB+170 B (+0.1%)
    react-native264 kB264 kB+170 B (+0.1%)
  • @firebase/firestore-lite

    TypeBase (a80e29c)Merge (11fbce0)Diff
    browser80.5 kB80.7 kB+172 B (+0.2%)
    esm596.2 kB96.5 kB+297 B (+0.3%)
    main135 kB136 kB+446 B (+0.3%)
    module80.5 kB80.7 kB+172 B (+0.2%)
    react-native80.7 kB80.9 kB+172 B (+0.2%)
  • bundle

    12 size changes

    TypeBase (a80e29c)Merge (11fbce0)Diff
    firestore (Persistence)274 kB274 kB+170 B (+0.1%)
    firestore (Query Cursors)211 kB211 kB+163 B (+0.1%)
    firestore (Query)212 kB212 kB+163 B (+0.1%)
    firestore (Read data once)200 kB200 kB+163 B (+0.1%)
    firestore (Realtime updates)202 kB203 kB+163 B (+0.1%)
    firestore (Transaction)184 kB184 kB+163 B (+0.1%)
    firestore (Write data)184 kB184 kB+163 B (+0.1%)
    firestore-lite (Query Cursors)68.0 kB68.2 kB+172 B (+0.3%)
    firestore-lite (Query)71.2 kB71.4 kB+172 B (+0.2%)
    firestore-lite (Read data once)55.6 kB55.8 kB+169 B (+0.3%)
    firestore-lite (Transaction)80.2 kB80.3 kB+172 B (+0.2%)
    firestore-lite (Write data)65.4 kB65.5 kB+172 B (+0.3%)

  • firebase

    TypeBase (a80e29c)Merge (11fbce0)Diff
    firebase-compat.js794 kB795 kB+170 B (+0.0%)
    firebase-firestore-compat.js314 kB314 kB+170 B (+0.1%)
    firebase-firestore-lite.js267 kB267 kB+399 B (+0.1%)
    firebase-firestore.js851 kB852 kB+397 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sf9vPrVm2c.html

@google-oss-bot
Copy link
Contributor

@github-actions github-actions bot added the doc-changes PRs that affect docs label Aug 5, 2022
/**
* A single field element in an index configuration.
*/
/** @beta */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be in the same comment block e.g.

/**
 * A single field element in an index configuration.
 * @beta
 */

Same for other occurrences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@wu-hui wu-hui merged commit ac578e9 into master Aug 6, 2022
@wu-hui wu-hui deleted the wuandy/BetaIndex branch August 6, 2022 01:17
@firebase firebase locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
doc-changes PRs that affect docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants