Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract uuid function into @firebase/util #6363

Merged
merged 64 commits into from
Jun 16, 2022
Merged

Conversation

maneesht
Copy link
Contributor

Extracted out duplicated uuid function into common util package

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2022

🦋 Changeset detected

Latest commit: 199478c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@firebase/app-check Patch
@firebase/database Patch
@firebase/util Patch
@firebase/app-check-compat Patch
firebase Patch
@firebase/database-compat Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/auth-compat Patch
@firebase/auth Patch
@firebase/component Patch
@firebase/database-types Patch
@firebase/firestore-compat Patch
@firebase/firestore Patch
@firebase/functions-compat Patch
@firebase/functions Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch
@firebase/storage-compat Patch
@firebase/storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 16, 2022

Size Report 1

Affected Products

  • @firebase/app-check

    TypeBase (578dc58)Merge (29b1bba)Diff
    browser25.3 kB25.1 kB-147 B (-0.6%)
    esm529.9 kB29.8 kB-153 B (-0.5%)
    main31.1 kB31.0 kB-155 B (-0.5%)
    module25.3 kB25.1 kB-147 B (-0.6%)
  • @firebase/util

    TypeBase (578dc58)Merge (29b1bba)Diff
    browser20.5 kB20.7 kB+168 B (+0.8%)
    esm521.9 kB22.0 kB+172 B (+0.8%)
    main26.7 kB26.9 kB+226 B (+0.8%)
    module20.5 kB20.7 kB+168 B (+0.8%)
  • bundle

    TypeBase (578dc58)Merge (29b1bba)Diff
    app-check (CustomProvider)35.4 kB35.4 kB+7 B (+0.0%)
    app-check (ReCaptchaEnterpriseProvider)37.6 kB37.6 kB+7 B (+0.0%)
    app-check (ReCaptchaV3Provider)37.5 kB37.5 kB+7 B (+0.0%)
  • firebase

    TypeBase (578dc58)Merge (29b1bba)Diff
    firebase-app-check-compat.js22.8 kB22.8 kB+27 B (+0.1%)
    firebase-app-check.js90.2 kB90.9 kB+669 B (+0.7%)
    firebase-auth-react-native.js495 kB496 kB+970 B (+0.2%)
    firebase-compat.js794 kB794 kB+25 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bn6xWD7B1C.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 16, 2022

Size Analysis Report 1

Affected Products

  • @firebase/app-check

    • initializeAppCheck

      Size

      TypeBase (578dc58)Merge (163940c)Diff
      size11.1 kB11.0 kB-137 B (-1.2%)
      size-with-ext-deps28.5 kB28.5 kB+7 B (+0.0%)

      Dependency

      TypeBase (578dc58)Merge (163940c)Diff
      functions

      36 dependencies

      _activate
      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken$2
      initTokenRefresher
      initializeAppCheck
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      readTokenFromIndexedDB
      readTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      sleep
      uuidv4
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage

      35 dependencies

      _activate
      addTokenListener
      computeKey
      createTokenRefresher
      ensureActivated
      exchangeToken
      factory
      formatDummyToken
      getDBPromise
      getDebugState
      getDebugToken
      getExchangeDebugTokenRequest
      getState
      getToken$2
      initTokenRefresher
      initializeAppCheck
      initializeDebugMode
      internalFactory
      isDebugMode
      isValid
      makeDummyTokenResult
      notifyTokenListeners
      read
      readDebugTokenFromIndexedDB
      readOrCreateDebugTokenFromStorage
      readTokenFromIndexedDB
      readTokenFromStorage
      registerAppCheck
      removeTokenListener
      setState
      sleep
      write
      writeDebugTokenToIndexedDB
      writeTokenToIndexedDB
      writeTokenToStorage

      - uuidv4

      External Dependency

      ModuleBase (578dc58)Merge (163940c)Diff
      @firebase/util

      Deferred
      ErrorFactory
      base64
      getGlobal
      getModularInstance
      isIndexedDBAvailable

      Deferred
      ErrorFactory
      base64
      getGlobal
      getModularInstance
      isIndexedDBAvailable
      uuidv4

      + uuidv4

  • @firebase/util

    • uuidv4

      Size

      TypeBase (578dc58)Merge (163940c)Diff
      size?176 B? (?)
      size-with-ext-deps?176 B? (?)

      Dependency

      TypeBase (578dc58)Merge (163940c)Diff
      functions??
      classes??
      variables?

      uuidv4

      ?
      enums??

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/c9M7H7cLBq.html

@maneesht maneesht marked this pull request as ready for review June 16, 2022 16:21
@maneesht maneesht assigned maneesht and hsubox76 and unassigned maneesht Jun 16, 2022
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, just a few changes.

@@ -0,0 +1,8 @@
---
"@firebase/app-check": patch
"@firebase/app": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are any files from app in this change?

common/api-review/util.api.md Show resolved Hide resolved
packages/util/src/uuid.ts Show resolved Hide resolved
packages/util/index.ts Show resolved Hide resolved
@maneesht maneesht merged commit efe2000 into master Jun 16, 2022
@maneesht maneesht deleted the mtewani/extract-uuidv4 branch June 16, 2022 22:28
@google-oss-bot google-oss-bot mentioned this pull request Jun 21, 2022
@firebase firebase locked and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants