Update build scripts to work with exports #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
avolkovi,
erikeldridge,
hiranya911,
hsubox76,
jposuna,
jsdt,
lisajian,
sam-gc,
schmidt-sebastian,
yoyomyo,
yuchenshi and
zwu52
as code owners
🦋 Changeset detectedLatest commit: 3f22cb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yuchenshi
reviewed
Nov 5, 2021
| @@ -243,7 +243,7 @@ const completeBuilds = [ | |||
| plugins: [ | |||
| sourcemaps(), | |||
| resolveModule({ | |||
| mainFields: ['lite-esm5', 'esm5', 'module'] | |||
| exportConditions: ['liteesm5', 'esm5'] | |||
There was a problem hiding this comment.
Is liteesm5 missing a dash here?
There was a problem hiding this comment.
no, it's intentional to not include a dash here because rollup doesn't seem to like it.
yuchenshi
approved these changes
Nov 5, 2021
Binary Size ReportAffected SDKs
Test Logs |
Size Analysis Report |
allspain
approved these changes
Nov 6, 2021
|
Approved but Yuchen's comment should be responded to prior to merging |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes firebase/firebase-admin-node#1487