Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Add SAML provider to the compat layer #5689

Merged
merged 2 commits into from
Nov 1, 2021
Merged

[Auth] Add SAML provider to the compat layer #5689

merged 2 commits into from
Nov 1, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Nov 1, 2021

Fixes b/204777785

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2021

🦋 Changeset detected

Latest commit: a11208c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth-compat Patch
@firebase/auth Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Nov 1, 2021
@sam-gc sam-gc requested a review from egilmorez as a code owner November 1, 2021 18:01
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 1, 2021

Binary Size Report

Affected SDKs

  • @firebase/auth-compat

    Type Base (477bdef) Head (7b55cd5) Diff
    browser 19.7 kB 19.8 kB +38 B (+0.2%)
    esm5 26.6 kB 26.6 kB +38 B (+0.1%)
    main 29.1 kB 29.1 kB +49 B (+0.2%)
    module 19.7 kB 19.8 kB +38 B (+0.2%)
  • firebase

    Type Base (477bdef) Head (7b55cd5) Diff
    firebase-auth-compat.js 122 kB 123 kB +534 B (+0.4%)
    firebase-compat.js 751 kB 751 kB +536 B (+0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 1, 2021

Size Analysis Report

Affected Products

No changes between base commit (477bdef) and head commit (7b55cd5).

@sam-gc sam-gc merged commit 31bd6f2 into master Nov 1, 2021
@sam-gc sam-gc deleted the sam-gc/saml branch November 1, 2021 18:49
@google-oss-bot google-oss-bot mentioned this pull request Nov 2, 2021
@firebase firebase locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants