Add exports to all packages #5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
avolkovi,
erikeldridge,
hiranya911,
hsubox76,
jposuna,
jsdt,
lisajian,
sam-gc,
schmidt-sebastian,
yoyomyo,
yuchenshi and
zwu52
as code owners
hsubox76
reviewed
Oct 27, 2021
There was a problem hiding this comment.
I was a little confused about which builds need the emitModulePackageFile() plugin and which don't. Some seemed to be missing, but maybe there's a reason. I made a comment about how multiple instances of that plugin might be redundant if writing to the same directory but I don't think that applies to all "missing" plugin cases so maybe there's another reason they're not needed in those cases.
hsubox76
approved these changes
Oct 29, 2021
benmccann
approved these changes
Oct 29, 2021
|
As a SvelteKit + Firebase developer, very happy to see this 👍. Thanks! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportsto all packages@firebase/app/@firebase/app-compatto minimize dual package hazard@firebase/messaging/@firebase/messaging-compatbecause one of its dependenciesidbdoesn't support esm in Nodejs.Fixes #4846