Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changeset for v9 #5350

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Add changeset for v9 #5350

merged 4 commits into from
Aug 23, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@Feiyang1 Feiyang1 requested a review from egilmorez as a code owner August 23, 2021 07:19
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 7a39518

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2021 •
edited
Loading

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Error: Found mixed changeset tame-olives-compete
Found ignored packages: @firebase/rules-unit-testing
Found not ignored packages: firebase @firebase/firestore @firebase/firestore-compat @firebase/firestore-types @firebase/analytics @firebase/analytics-compat @firebase/analytics-types @firebase/app @firebase/app-check @firebase/app-check-compat @firebase/app-check-types @firebase/app-compat @firebase/app-types @firebase/auth @firebase/auth-compat @firebase/auth-types @firebase/database @firebase/database-compat @firebase/database-types @firebase/functions @firebase/functions-compat @firebase/functions-types @firebase/installations @firebase/installations-compat @firebase/installations-types @firebase/messaging @firebase/messaging-compat @firebase/messaging-types @firebase/messaging-interop-types @firebase/performance @firebase/performance-compat @firebase/performance-types @firebase/remote-config @firebase/remote-config-compat @firebase/remote-config-types @firebase/storage @firebase/storage-compat @firebase/storage-types
Mixed changesets that contain both ignored and not ignored packages are not allowed
    at Object.assembleReleasePlan [as default] (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/assemble-release-plan/dist/assemble-release-plan.cjs.dev.js:418:30)
    at Object.getReleasePlan [as default] (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/get-release-plan/dist/get-release-plan.cjs.dev.js:71:49)
    at async getStatus (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:972:23)
    at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1227:11)

hsubox76
hsubox76 reviewed Aug 23, 2021
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions:

  1. Is firestore special? (no compat or types)?
  2. Should we also bump interop types packages?

@hsubox76 hsubox76 assigned Feiyang1 and unassigned hsubox76 Aug 23, 2021
@Feiyang1
Copy link
Member Author

2 questions:

  1. Is firestore special? (no compat or types)?

Waiting on #5319

  1. Should we also bump interop types packages?

nop, they have no changes.

@hsubox76
Copy link
Contributor

  1. Should we also bump interop types packages?

nop, they have no changes.

Ok just want to double check that the new messaging one we just made will get published. I get confused about how changeset works.

@Feiyang1
Copy link
Member Author

I thought I included it (messaging-interop-types), but apparently I didn't. Good catch.

hsubox76
hsubox76 approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending firestore updates.

@Feiyang1 Feiyang1 merged commit 616d6fd into fei-v9-main Aug 23, 2021
@Feiyang1 Feiyang1 deleted the fei-v9-main-changeset branch August 23, 2021 20:28
Feiyang1 added a commit that referenced this pull request Aug 24, 2021
@Feiyang1
Add changeset for v9 (#5350)
5d2d831 
* add changeset

* publish messaging interop

* add firestore bumps

* update changeset
Feiyang1 added a commit that referenced this pull request Aug 24, 2021
@Feiyang1
Add changeset for v9 (#5350)
924dd36 
* add changeset

* publish messaging interop

* add firestore bumps

* update changeset
Feiyang1 added a commit that referenced this pull request Aug 24, 2021
@Feiyang1
Add changeset for v9 (#5350)
d2b44ca 
* add changeset

* publish messaging interop

* add firestore bumps

* update changeset
Feiyang1 added a commit that referenced this pull request Aug 24, 2021
@Feiyang1 @schmidt-sebastian
@zwu52 @yuchenshi
Repo refactoring (#5345)
cdada6c 
* Split storage and storage-compat (#5271)

* separate storage-compat from storage

* commit

* fix tests

* wat?

* build storage-compat

* save

* fixing some compat tests

* format

* update import path

* format

* get compat tests to work

* format

* update package json

* cleanup

* format

* address comments

* Update packages/storage-compat/test/unit/service.test.ts

Co-authored-by: Christina Holland <[email protected]>

* add missing dev dep

* Update packages/storage-compat/package.json

* Update packages/storage-compat/package.json

* Update deps after v8 release

* update compat version

* Split database and database-compat (#5276)

* compile database

* pass database tests

* compile and test database-compat

* pass all tests

* prettier

* cleanup

* fix lint

* address comments

* what is going on with ci

* use correct case in import path

* uppercase

* rename

* fix component name

* Repo refactoring for v9 (#5325)

* rename folders

* rename folders

* migrate app and app-compat

* migrate installations and analytics

* migrate app check

* migrate auth

* migrate functions

* migrate messaging

* migrate performance

* migrate remoteconfig

* remove v8 code

* update versions

* migrate firebase

* fix merge issues

* save

* fix firebase builds

* update changeset config

* update build scripts

* update release script

* fix functions typings

* remove redundant typings

* update path

* treat external dependencies correctly

* fix lint

* remove firestore-compat references

* fix build issues

* update build scripts

* update pkg json

* fix test

* fix some tests

* fix some tests

* fix integration tests

* fixes

* fix dep

* update ci tests

* resolve todos

* remove exp references

* docgen build

* export FirebaseError (#5349)

* firebase packaging update (#5348)

* Fei v9 main firestore (#5319)

* compile firestore

* update typings path

* compile firestore compat

* lint compat

* make test work

* get most tests work

* build

* remove special paths

* update firestore-compat pkg json

* fix merge issues

* Simplify bundles

* Prettier

* Fix Bundle compile

* Fix build

* address comments

* console build

* Fix all tests

* Prettier

* fix merge issues

* fix typo

* update paths

* app-exp

* fix lint

* correct path

* fix

* fix compat lint

* fix firestore integration

* fix workflow

* update dep

* Always block on Auth (#5340)

* Always block on Auth

* Don't block on token if already recevied

* fix lint

* build firestore

* remove memory only tests

* fix firebase integration tests

* enable more build and tests

* add firestore-compat to firebase dep

* fix auth compat class

* enable auth test

* auth package doc

* Update API reports

Co-authored-by: Sebastian Schmidt <[email protected]>
Co-authored-by: Feiyang1 <[email protected]>

* rebasing

* Create registerMessagingCompat.ts

* Add changeset for v9 (#5350)

* add changeset

* publish messaging interop

* add firestore bumps

* update changeset

* Revert "Create registerMessagingCompat.ts"

This reverts commit 0b95a51.

* Revert "rebasing"

This reverts commit a8bf697.

* Update index.d.ts (#5355)

* Fix Context Check in `Messaging-Compat` (#5353)

* Add Rules Unit Testing v2 skeleton for v9 release (#5352)

* Reset package for next major version.

* Switch emulator script to node-fetch.

* Migrate the other request call to fetch.

* Update packages/rules-unit-testing/package.json

Co-authored-by: Feiyang <[email protected]>

* Create stale-ducks-live.md

* Revert version change.

Co-authored-by: Feiyang <[email protected]>

* fix import path (#5356)

* Add new types and function stubs for RUT vNext. (#5316)

* Add new types and function stubs.

* Fix types for testEnv.emulators.

* Add util functions.

* Add withFunctionTriggersDisabled overloads.

* Improve typing for EmulatorConfig.

* Fix tests.

* Rename test_environment.ts to initialize.ts.

* Add a dummy test to make CI pass.

* Implement emulators discovery in RUTv2. (#5334)

* Add new types and function stubs.

* Fix types for testEnv.emulators.

* Add util functions.

* Add withFunctionTriggersDisabled overloads.

* Improve typing for EmulatorConfig.

* Fix tests.

* Rename test_environment.ts to initialize.ts.

* Add a dummy test to make CI pass.

* Implement emulators discovery.

* Use URL object from global.

* Fix unreachable  error code.

* Implement most of RUTv2 features. (#5343)

* Implement most of RUTv2 features.

* Switch to compat instances.

* Remove legacy code.

* Use public typings for release (#5358)

* use public typings for storage

* use public typings for database

* Implement rest of RUTv2 features. (#5360)

* Implement loading rules and withFunctionTriggersDisabled.

* Implement clearFirestore and storage.

* Add missing await.

* Add default bucketUrl.

* Use alternative method to clear bucket.

* Use default param (review feedback).

* Storage typing updates (#5359)

* rename to StorageError

* more type safety

* Update API reports

* update api report

Co-authored-by: Feiyang1 <[email protected]>

* correct component name

* fix installtions-compat typing

* remove rules-unit-testing from ignore list

* reenable things

* support mjs files

* correct matching pattern

* transform only @firebase/util

* use public types for database doc

* transform all but compat packages

Co-authored-by: Sebastian Schmidt <[email protected]>
Co-authored-by: Feiyang1 <[email protected]>
Co-authored-by: kai <[email protected]>
Co-authored-by: Yuchen Shi <[email protected]>
Co-authored-by: Kai Wu <[email protected]>
@firebase firebase locked and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Feiyang1 @hsubox76