Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Implement origin validation for fast erroring-out in Cordova popup redirect resolver #5103

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 1, 2021

This addresses b/184783577

@sam-gc sam-gc requested a review from yuchenshi July 1, 2021 23:52
@sam-gc sam-gc requested a review from avolkovi as a code owner July 1, 2021 23:52
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2021

⚠️ No Changeset found

Latest commit: e7e79eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sam-gc sam-gc changed the base branch from master to sam-gc/eslint July 1, 2021 23:52
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
    Error: Failed to find where HEAD diverged from master. Does master exist?
        at async getChangedFilesSince (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:169:22)
        at async Object.getChangedPackagesSinceRef (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/git/dist/git.cjs.dev.js:208:24)
        at async getStatus (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:977:27)
        at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1227:11)
    

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021

Binary Size Report

Affected SDKs

No changes between base commit (db98eda) and head commit (637067e).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2021

Size Analysis Report

Affected Products

Diffs between base commit (db98eda) and head commit (637067e) are too large (517,485 characters) to display.

Please check below links to see details from the original test log.

Base automatically changed from sam-gc/eslint to master July 2, 2021 17:43
@sam-gc sam-gc force-pushed the sam-gc/cordova-origin branch from 3f3f1aa to e7e79eb Compare July 2, 2021 17:44
@sam-gc sam-gc merged commit 821f4d3 into master Jul 2, 2021
@sam-gc sam-gc deleted the sam-gc/cordova-origin branch July 2, 2021 18:22
@firebase firebase locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants