Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Fetch in firestore@beta #4939

Merged
merged 7 commits into from
May 27, 2021
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented May 25, 2021

This changes the v9 SDK to use fetch instead of XHR when communicating to the backend. This unblocks SDK support for more JavaScript environments.

Fixes #4912

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2021

⚠️ No Changeset found

Latest commit: cc9ccda

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 25, 2021

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (22c2621) Head (c519cab) Diff
    browser 284 kB 284 kB +272 B (+0.1%)
    esm2017 226 kB 227 kB +260 B (+0.1%)
    main 531 kB 531 kB +172 B (+0.0%)
    module 284 kB 284 kB +272 B (+0.1%)
    react-native 226 kB 227 kB +258 B (+0.1%)
  • @firebase/firestore-exp

    Type Base (22c2621) Head (c519cab) Diff
    browser 224 kB 224 kB +307 B (+0.1%)
    main 510 kB 511 kB +215 B (+0.0%)
    module 224 kB 224 kB +307 B (+0.1%)
    react-native 224 kB 224 kB +293 B (+0.1%)
  • @firebase/firestore-lite

    Type Base (22c2621) Head (c519cab) Diff
    browser 72.6 kB 72.7 kB +126 B (+0.2%)
    main 149 kB 149 kB +172 B (+0.1%)
    module 72.6 kB 72.7 kB +126 B (+0.2%)
    react-native 72.8 kB 72.9 kB +126 B (+0.2%)
  • @firebase/firestore/bundle

    Type Base (22c2621) Head (c519cab) Diff
    browser 290 kB 290 kB +272 B (+0.1%)
    esm2017 176 kB 177 kB +260 B (+0.1%)
    main 527 kB 527 kB +172 B (+0.0%)
    module 290 kB 290 kB +272 B (+0.1%)
    react-native 177 kB 177 kB +258 B (+0.1%)
  • @firebase/firestore/memory

    Type Base (22c2621) Head (c519cab) Diff
    browser 216 kB 217 kB +255 B (+0.1%)
    esm2017 172 kB 172 kB +260 B (+0.2%)
    main 325 kB 325 kB +172 B (+0.1%)
    module 216 kB 217 kB +255 B (+0.1%)
    react-native 172 kB 172 kB +258 B (+0.1%)
  • @firebase/firestore/memory-bundle

    Type Base (22c2621) Head (c519cab) Diff
    browser 224 kB 225 kB +255 B (+0.1%)
    esm2017 176 kB 177 kB +260 B (+0.1%)
    main 322 kB 322 kB +172 B (+0.1%)
    module 224 kB 225 kB +255 B (+0.1%)
    react-native 177 kB 177 kB +258 B (+0.1%)
  • @firebase/webchannel-wrapper

    Type Base (22c2621) Head (c519cab) Diff
    esm2017 39.5 kB 42.2 kB +2.68 kB (+6.8%)
    main 46.9 kB 49.6 kB +2.74 kB (+5.8%)
    module 40.8 kB 43.5 kB +2.68 kB (+6.6%)
  • firebase

    Type Base (22c2621) Head (c519cab) Diff
    firebase-firestore.js 332 kB 335 kB +2.77 kB (+0.8%)
    firebase-firestore.memory.js 267 kB 270 kB +2.77 kB (+1.0%)
    firebase.js 889 kB 891 kB +2.78 kB (+0.3%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 25, 2021

Size Analysis Report

Affected Products

Diffs between base commit (22c2621) and head commit (c519cab) are too large (477,920 characters) to display.

Please check below links to see details from the original test log.

@schmidt-sebastian schmidt-sebastian merged commit 55ecffe into master May 27, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fetchstreams branch May 27, 2021 20:44
@firebase firebase locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Use fetch() in v9 instead of XMLHttpRequest
4 participants